Skip to content

Commit

Permalink
fix: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Alok committed Aug 13, 2024
1 parent e3b49d6 commit 4abbb53
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/infrastructure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,9 @@ jobs:
go build -ldflags="-s -w" -o mev-commit-test ./cmd/main.go
./mev-commit-test \
--settlement-rpc-endpoint ws://127.0.0.1:8546 \
--bootnode-rpc-urls http://127.0.0.1:13524 \
--provider-rpc-urls http://127.0.0.1:13624 \
--bidder-rpc-urls http://127.0.0.1:13724
--bootnode-rpc-urls 127.0.0.1:13524 \
--provider-rpc-urls 127.0.0.1:13624 \
--bidder-rpc-urls 127.0.0.1:13724
- name: Notify - Deployment Successful
if: ${{ env.IS_MANUAL_DEPLOYMENT == 'true' && success() }}
Expand Down
7 changes: 4 additions & 3 deletions testing/cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package main

import (
"fmt"
"net"
"net/url"
"os"
"slices"
Expand Down Expand Up @@ -110,7 +111,7 @@ var (
return fmt.Errorf("at least one bootnode RPC address is required")
}
for _, address := range addresses {
if _, err := url.Parse(address); err != nil {
if _, _, err := net.SplitHostPort(address); err != nil {
return fmt.Errorf("invalid bootnode RPC address: %w", err)
}
}
Expand All @@ -127,7 +128,7 @@ var (
return fmt.Errorf("at least one provider RPC address is required")
}
for _, address := range addresses {
if _, err := url.Parse(address); err != nil {
if _, _, err := net.SplitHostPort(address); err != nil {
return fmt.Errorf("invalid provider RPC address: %w", err)
}
}
Expand All @@ -144,7 +145,7 @@ var (
return fmt.Errorf("at least one bidder RPC address is required")
}
for _, address := range addresses {
if _, err := url.Parse(address); err != nil {
if _, _, err := net.SplitHostPort(address); err != nil {
return fmt.Errorf("invalid bidder RPC address: %w", err)
}
}
Expand Down

0 comments on commit 4abbb53

Please sign in to comment.