Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensures zero fee address is correctly set #54

Merged
merged 4 commits into from
Nov 27, 2024
Merged

feat: ensures zero fee address is correctly set #54

merged 4 commits into from
Nov 27, 2024

Conversation

ckartik
Copy link

@ckartik ckartik commented Nov 26, 2024 •
edited
Loading 

.primev % cast balance 0xADB4257612d45f12570533308b20AC77DBfeB85a
50000000000000000000
.primev % cast send --from 0xADB4257612d45f12570533308b20AC77DBfeB85a --private-key cf194d7afcff3cf4245650389232b58ea13d6bbe744463d88e66ce45ce6c0034 0x0000000000000000000000000000000000000000 --value 1

blockHash               0x8d3b34a53fbd5cdb0f4a5e1ecc185c8261fe6f7e118887c27130418d006cb1fa
blockNumber             2
contractAddress
cumulativeGasUsed       21000
effectiveGasPrice       766024068
from                    0xADB4257612d45f12570533308b20AC77DBfeB85a
gasUsed                 21000
logs                    []
logsBloom               0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
root
status                  1 (success)
transactionHash         0x10edf9347c1cb9cd0b4376cf5e6ad3e46d4543c3a3701959d50005c04bd4f0f2
transactionIndex        0
type                    2
blobGasPrice
blobGasUsed
authorizationList
to                      0x0000000000000000000000000000000000000000
.primev % cast balance 0xADB4257612d45f12570533308b20AC77DBfeB85a

49999999999999999999

Observe above that the balance is only decremented 1 wei on a transfer of 1 wei, meaning the zero-fee-address paid zero in transaction fees.

aloknerurkar
aloknerurkar approved these changes Nov 26, 2024
View reviewed changes
geth-poa/genesis.json
@@ -1,74 +1,32 @@
{
"config": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed?

@mrekucci mrekucci merged commit 7cb1fc1 into master Nov 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloknerurkar aloknerurkar aloknerurkar approved these changes

@mrekucci mrekucci mrekucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckartik @mrekucci @aloknerurkar