-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix borderColor-closed-muted and revert open colors to orange in protanopia-deuteranopia #1154
Conversation
🦋 Changeset detectedLatest commit: 6ae426c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0025407
to
b3c0518
Compare
b3c0518
to
016fce2
Compare
@lukasoppermann I think the approach I would take here would be to restore colors as close as possible to the hue range used prior to this update—unsure what colors were used where, however. |
This comment was marked as outdated.
This comment was marked as outdated.
9cfee81
to
5463b17
Compare
5463b17
to
529ee84
Compare
Design Token Diff (CSS)
|
Design Token Diff (StyleLint)
|
Design Token Diff (Figma)
|
6fec720
to
c050904
Compare
c050904
to
7ab767e
Compare
Summary
This is the implementation of the fix for https://github.com/github/primer/issues/4667
Changes
borderColor-closed-muted
in Dark protanopia-deuteranopia is nowgray
instead oforange
borderColor-open-[muted|emphasis]
in protanopia-deuteranopia is noworange
again (instead ofblue
)fgColor-open
in protanopia-deuteranopia is noworange
again (instead ofblue
)bgColor-open-[muted|emphasis]
in protanopia-deuteranopia is noworange
again (instead ofblue
)Solution
borderColor-closed-muted
in Dark Protanopia to orangeChanges
borderColor-closed-muted
in Dark Protanopiaopen
colors for Protanopia to useorange
open
closed
Old solution idea
Discussion point
As one can see in the screenshots below, while blue may "feel" more fitting for "open", it contrasts a lot worse with other colors like "done" (purple).
I believe this is why the theme originally used red instead of blue (light mode was like this, dark mode had a bug which is why it never showed up as red).
Possible solutions
Changes
open
colors to referencesuccess
colors for Dark and Light Tritanopiaopen
closed
GitHub UI
Light Tritanopia
Dark Tritanopia
Light Protanopia & Deuteranopia
Dark Protanopia & Deuteranopia