Add new generic on PgStore and converter trait to decouple persistence from Aggregate::Event #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnabell
force-pushed
the
decouple-persistence
branch
from
9ebfc46 to
ff9bac4
Compare
…e from Aggregate::Event
Johnabell
force-pushed
the
decouple-persistence
branch
from
ff9bac4 to
25d3329
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
from
0f21d16 to
dea2073
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
2 times, most recently
from
8fb9d09 to
7f55781
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
from
7f55781 to
0bef40c
Compare
There was a problem hiding this comment.
Thank you for this PR. Very nice solution and top for the non-breaking change!
Only some notes (collected together in the meet) regarding some changes that would be worth it doing in this PR:
- Split
schemaexample into multiple examples, trying to let examples as easy as possible. - Update readme with a section like "Decoupe Aggregate Event from DB Event (Schema)"
- Rename
Eventtrait to be a bit more consistent to its role. - Rename some generics to be a one-letter-only generic?
Johnabell
force-pushed
the
decouple-persistence
branch
from
15bf67c to
e75ac61
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
8 times, most recently
from
7c653e9 to
0dcb1db
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
6 times, most recently
from
bd186b7 to
1841719
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
from
1841719 to
4a9077b
Compare
Johnabell
commented
Mar 27, 2024
| @@ -1 +1 @@ | |||
| msrv = "1.58.0" | |||
| msrv = "1.74.0" | |||
There was a problem hiding this comment.
The project currently does not compile with version 1.73.0. We can fix the issue in the crate itself, but it looks like sqlx-core-0.7.4 does not compile with 1.73.0 either. If we wanted to address this we might need to use an older version.
There was a problem hiding this comment.
I think it's fine to set 1.74 as minimum version
Johnabell
force-pushed
the
decouple-persistence
branch
2 times, most recently
from
7463ffe to
95396c6
Compare
Johnabell
force-pushed
the
decouple-persistence
branch
from
95396c6 to
0b165f8
Compare
cottinisimone
previously approved these changes
Mar 29, 2024
Johnabell
force-pushed
the
decouple-persistence
branch
from
769d131 to
69ef2d3
Compare
angelo-rendina-prima
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to decouple the persistence from the domain Aggregate::Event types.
This removes the need to Aggregate::Event to implement the Event trait to work with PgStore.
It simultaneously provides a way to deprecate events without the effects propagating through a code base. Furthermore it provides an alternative way to upcast events.
I have added an example to demonstrate the use case of deprecation and upcasting.