Code

Support role management (v3)#10904

Code

Closed

findepi wants to merge 57 commits intoprestodb:masterprestodb/presto:masterfrom starburstdata:epic/support-role-management/pr3starburstdata/facebook-presto:epic/support-role-management/pr3Copy head branch name to clipboard

+7,643-1,104

Commits

Commits on Jun 26, 2018

• Introduce CREATE ROLE and DROP ROLE statements

  

  Andrii Rosa

  authored and

  findepi

  committed
  aef4030

  Copy full SHA for aef4030

• Move PrincipalType to presto-spi

  

  Andrii Rosa

  authored and

  findepi

  committed
  54dd85f

  Copy full SHA for 54dd85f

• Expose Create/Drop/List roles methods in SPI

  

  Andrii Rosa

  authored and

  findepi

  committed
  9681b93

  Copy full SHA for 9681b93

• Introduce <catalog>.information_schema.roles table

  

  Andrii Rosa

  authored and

  findepi

  committed
  ad6f88a

  Copy full SHA for ad6f88a

• Assign admin role to subset of users in FileHiveMetastore

  

  Andrii Rosa

  authored and

  findepi

  committed
  a083428

  Copy full SHA for a083428

• Implement Create/Drop/List roles in Hive connector

  

  Andrii Rosa

  authored and

  findepi

  committed
  16176e7

  Copy full SHA for 16176e7

• Introduce GRANT/REVOKE roles statements

  

  Andrii Rosa

  authored and

  findepi

  committed
  db56f71

  Copy full SHA for db56f71

• Add Grant/Revoke/List roles authorization to the SPI

  

  Andrii Rosa

  authored and

  findepi

  committed
  d8aa107

  Copy full SHA for d8aa107

• Introduce APPLICABLE_ROLES view

  

  Andrii Rosa

  authored and

  findepi

  committed
  2f2a8e5

  Copy full SHA for 2f2a8e5

• Implement Grant/Revoke/ListApplicableRoles in Hive

  

  Andrii Rosa

  authored and

  findepi

  committed
  be94995

  Copy full SHA for be94995

• Refactor GRANT/REVOKE in Hive

  Show description for 76e8579
  

  Andrii Rosa

  authored and

  findepi

  committed
  76e8579

  Copy full SHA for 76e8579

• Introduce access control for GRANT/REVOKE ROLE

  

  Andrii Rosa

  authored and

  findepi

  committed
  71fcd54

  Copy full SHA for 71fcd54

• Prepare metastore interface to accept ROLE for GRANT/REVOKE

  

  Andrii Rosa

  authored and

  findepi

  committed
  c25c837

  Copy full SHA for c25c837

• Introduce SET ROLE statement

  

  Andrii Rosa

  authored and

  findepi

  committed
  ba79f9f

  Copy full SHA for ba79f9f

• Introduce ConnectorIdentity

  Show description for 344461c
  

  Andrii Rosa

  authored and

  findepi

  committed
  344461c

  Copy full SHA for 344461c

• Implement SET ROLE

  

  Andrii Rosa

  authored and

  findepi

  committed
  9b20efc

  Copy full SHA for 9b20efc

• Store catalog selected roles in Identity

  

  Andrii Rosa

  authored and

  findepi

  committed
  e99cc70

  Copy full SHA for e99cc70

• Introduce ENABLED_ROLES view

  

  Andrii Rosa

  authored and

  findepi

  committed
  be83bae

  Copy full SHA for be83bae

• Implement SET ROLE in Hive Connector

  

  Andrii Rosa

  authored and

  findepi

  committed
  3252b40

  Copy full SHA for 3252b40

• Accept ROLE in GRANT/REVOKE Privileges statements

  

  Andrii Rosa

  authored and

  findepi

  committed
  380c4f6

  Copy full SHA for 380c4f6

• Add SHOW ROLES to the parser

  

  cawallin

  authored and

  findepi

  committed
  541ed4f

  Copy full SHA for 541ed4f

• Rewrite SHOW ROLES as a select query

  Show description for aae58b0
  

  cawallin

  authored and

  findepi

  committed
  aae58b0

  Copy full SHA for aae58b0

• Add access control checks for SHOW ROLES

  

  cawallin

  authored and

  findepi

  committed
  84e10ac

  Copy full SHA for 84e10ac

• Add docs for SHOW ROLES

  

  cawallin

  authored and

  findepi

  committed
  7b192d3

  Copy full SHA for 7b192d3

• Product tests for SHOW ROLES

  

  cawallin

  authored and

  findepi

  committed
  340606e

  Copy full SHA for 340606e

• Add SHOW CURRENT ROLES

  Show description for f7c5f55
  

  cawallin

  authored and

  findepi

  committed
  f7c5f55

  Copy full SHA for f7c5f55

• Add SHOW ROLE GRANTS syntax

  

  cawallin

  authored and

  findepi

  committed
  f422c17

  Copy full SHA for f422c17

• Add listRoleGrants to the SPI

  

  cawallin

  authored and

  findepi

  committed
  c011dbe

  Copy full SHA for c011dbe

• Implement listRoleGrants() in Hive

  

  cawallin

  authored and

  findepi

  committed
  36fd670

  Copy full SHA for 36fd670

• Implement SHOW ROLE GRANTS rewrite

  

  cawallin

  authored and

  findepi

  committed
  0954977

  Copy full SHA for 0954977

• Add docs for SHOW ROLE GRANTS

  

  cawallin

  authored and

  findepi

  committed
  126896d

  Copy full SHA for 126896d

• Access control for SHOW ROLE GRANTS and SHOW CURRENT ROLES

  

  cawallin

  authored and

  findepi

  committed
  71d66b9

  Copy full SHA for 71d66b9

• Remove redundant checkDatabasePermission methods

  Show description for 31111ed
  

  Andrii Rosa

  authored and

  findepi

  committed
  31111ed

  Copy full SHA for 31111ed

• Reorder methods in SqlStandardAccessControl

  

  Andrii Rosa

  authored and

  findepi

  committed
  851231e

  Copy full SHA for 851231e

• Rename getGrantOptionForPrivilege to hasGrantOptionForPrivilege

  

  Andrii Rosa

  authored and

  findepi

  committed
  1d9012f

  Copy full SHA for 1d9012f

• Remove hive privilege null check

  

  Andrii Rosa

  authored and

  findepi

  committed
  652e71e

  Copy full SHA for 652e71e

• Allow all for admin role

  Show description for 766fc6b
  

  Andrii Rosa

  authored and

  findepi

  committed
  766fc6b

  Copy full SHA for 766fc6b

• Introduce isTableOwner method for readability

  

  Andrii Rosa

  authored and

  findepi

  committed
  4120f66

  Copy full SHA for 4120f66

• Simplify checkTablePermission

  

  Andrii Rosa

  authored and

  findepi

  committed
  2a39d1b

  Copy full SHA for 2a39d1b

• Refactor canCreateView security checks

  Show description for 0716453
  

  Andrii Rosa

  authored and

  findepi

  committed
  0716453

  Copy full SHA for 0716453

• Consider enabled roles for permissions

  

  Andrii Rosa

  authored and

  findepi

  committed
  4f30efb

  Copy full SHA for 4f30efb

• Refactor HivePrivilegeInfo

  

  Andrii Rosa

  authored and

  findepi

  committed
  3a08bda

  Copy full SHA for 3a08bda

• Reorder methods in HivePrivilegeInfo

  

  Andrii Rosa

  authored and

  findepi

  committed
  36033c6

  Copy full SHA for 36033c6

• Move parsePrivilege to MetastoreUtil

  

  Andrii Rosa

  authored and

  findepi

  committed
  fc27524

  Copy full SHA for fc27524

• Add grantor to HivePrivilegeInfo

  

  Andrii Rosa

  authored and

  findepi

  committed
  07e87b5

  Copy full SHA for 07e87b5

• Add grantor_type and grantee_type columns to table_privileges

  

  Andrii Rosa

  authored and

  findepi

  committed
  5fabb58

  Copy full SHA for 5fabb58

• More product tests for SET ROLE

  Show description for db09600
  

  Andrii Rosa

  authored and

  findepi

  committed
  db09600

  Copy full SHA for db09600

• Document role management

  

  Andrii Rosa

  authored and

  findepi

  committed
  be969ff

  Copy full SHA for be969ff

• Catalog access control for roles

  

  Andrii Rosa

  authored and

  findepi

  committed
  06abb42

  Copy full SHA for 06abb42

• Remove unused metastore statistics beans

  

  kokosing

  authored and

  findepi

  committed
  9dd2d7e

  Copy full SHA for 9dd2d7e

• Extract role name constants

  

  kokosing

  authored and

  findepi

  committed
  3961475

  Copy full SHA for 3961475

• Enumerate roles until enabled role is found

  Show description for f1faf66
  

  kokosing

  authored and

  findepi

  committed
  f1faf66

  Copy full SHA for f1faf66

Commits on Jun 28, 2018

• Make ThriftMetastoreUtil.list*Roles methods to return Stream

  Show description for 359cd06
  kokosing

  committed
  359cd06

  Copy full SHA for 359cd06

• Make list*TablePrivileges to return Stream

  Show description for 666a34a
  kokosing

  committed
  666a34a

  Copy full SHA for 666a34a

Commits on Jul 30, 2018

• Fix listing privileges of tables owned by an user

  Show description for f0ec317
  anusudarsan

  committed
  f0ec317

  Copy full SHA for f0ec317

• Fix listing privileges when admin role is set

  Show description for 2c44180
  anusudarsan

  committed
  2c44180

  Copy full SHA for 2c44180

• fixup! Rewrite SHOW GRANTS as a SELECT query

  Show description for 94539e9
  

  kokosing

  authored and

  anusudarsan

  committed
  94539e9

  Copy full SHA for 94539e9