Fix EXPLAIN(TYPE VALIDATE) of EXPLAIN queries

Previously queries like `EXPLAIN (TYPE VALIDATE) EXPLAIN (TYPE IO) SELECT 1` would fail with the error "Non analyze explain should be rewritten to Query". This adds proper support for such queries.
prestodb · Aug 22, 2023 · 7edd2c2 · 7edd2c2
1 parent 8499cd3
commit 7edd2c2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/presto-main/src/main/java/com/facebook/presto/sql/rewrite/ExplainRewrite.java b/presto-main/src/main/java/com/facebook/presto/sql/rewrite/ExplainRewrite.java
@@ -90,7 +90,7 @@ protected Node visitExplain(Explain node, Void context)
                 throws SemanticException
         {
             if (isTypeValidate(node)) {
-                return node.getStatement();
+                return process(node.getStatement());
             }
 
             if (node.isAnalyze()) {

diff --git a/presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java b/presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java
@@ -2564,6 +2564,14 @@ public void testExplainOfExplainAnalyze()
         assertEquals(getOnlyElement(result.getOnlyColumnAsSet()), getExplainPlan("EXPLAIN ", query, LOGICAL));
     }
 
+    @Test
+    public void testExplainValidateOfExplain()
+    {
+        String query = "EXPLAIN SELECT 1";
+        MaterializedResult result = computeActual("EXPLAIN (TYPE VALIDATE) " + query);
+        assertEquals(result.getOnlyValue(), true);
+    }
+
     @Test
     public void testExplainDdl()
     {