feat(accessiblity-support): Add accessibility (a11y) support for the player #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accessibility (a11y) support for the player
This pull request add the support for screen reader
Description
The player didn't work well with screen reader. The "show / hide" feature on touch and the
autoDismissfeature were hiding the controls from the reader.Now the library checks wether the user has the screen reader enabled, if so the controls will always be visibile.
I also added the possibility to pass Accessibility props to some custom components such as:
ControlSliderReTextAnd default a11y props to the Slider
Related Issues
Closes #2
Testing
iOS
Documentation
Checklist
Additional Notes
I also updated the expo packages