feat: app router support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78b6728 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tlenclos
reviewed
Nov 29, 2023
tlenclos
reviewed
Nov 29, 2023
tlenclos
reviewed
Nov 29, 2023
tlenclos
reviewed
Nov 29, 2023
tlenclos
reviewed
Nov 29, 2023
tlenclos
reviewed
Nov 29, 2023
tlenclos
reviewed
Nov 29, 2023
Comment on lines
139
to
183
| data.forEach((item, index) => { | ||
| Object.keys(item).forEach((key) => { | ||
| let itemValue; | ||
|
|
||
| if (typeof item[key] === "object" && item[key] !== null) { | ||
| switch (item[key].type) { | ||
| case "link": | ||
| itemValue = item[key].value.label; | ||
| break; | ||
| case "count": | ||
| itemValue = item[key].value; | ||
| break; | ||
| case "date": | ||
| itemValue = item[key].value.toString(); | ||
| break; | ||
| default: | ||
| itemValue = item[key].id; | ||
| break; | ||
| } | ||
|
|
||
| item[key].__nextadmin_formatted = itemValue; | ||
| } else if (isScalar(item[key]) && item[key] !== null) { | ||
| item[key] = { | ||
| type: "scalar", | ||
| value: item[key], | ||
| __nextadmin_formatted: item[key].toString(), | ||
| }; | ||
| itemValue = item[key].value; | ||
| } | ||
|
|
||
| if ( | ||
| appDir && | ||
| key in listFields && | ||
| listFields[key as keyof typeof listFields]?.formatter && | ||
| !!itemValue | ||
| ) { | ||
| item[key].__nextadmin_formatted = listFields[ | ||
| key as keyof typeof listFields | ||
| // @ts-expect-error | ||
| ]?.formatter?.(itemValue ?? item[key]); | ||
| } else { | ||
| data[index][key] = item[key]; | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Why do we need these new formatters ?
There was a problem hiding this comment.
So the initial behavior was to pass the options object as a prop of the NextAdmin component, which was causing issues with the fields with the formatter function since those were not serializable. So for the app router, the idea was to run the formatting on the server side. To achieve that, we needed to take the behavior of the Cell component and apply it on the server side
foyarash
force-pushed
the
feature/app-router
branch
from
6677a08 to
906d1fc
Compare
tlenclos
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54