Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/no results search #16

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Fix/no results search #16

merged 4 commits into from
Sep 18, 2023

Conversation

Lucieo
Copy link
Contributor

@Lucieo Lucieo commented Sep 14, 2023

Description

  • Distinguish in BookmarksTeamList if empty bookmark list is linked to no results in search or no bookmark available for team
  • Unify wording between DigestEditPage and BookmarksTeamList

Team without bookmark
image

Team search without search result
image

DigestEditPage without search result
image

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digestclub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 1:25pm

Copy link
Member

@baptadn baptadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Lucieo
Copy link
Contributor Author

Lucieo commented Sep 14, 2023

  • If no search results don't display Bookmarks controls
    image

@tlenclos
Copy link
Contributor

I can't properly see the "View all bookmarks" button
image

@Lucieo Lucieo merged commit f6f7cdf into main Sep 18, 2023
2 checks passed
@baptadn baptadn deleted the fix/no-results-search branch October 4, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants