Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable entity manager #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+84 −68
Open

Configurable entity manager #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea0a8af
Add option to configure which entity manager to use
yberkholz Nov 25, 2012
223c965
Change the naming of entity manger configuration and create base comm…
yberkholz Jan 1, 2013
52aac0e
Update composer.json
yberkholz Mar 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Command/CronDisableJobCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ protected function configure()
protected function execute(InputInterface $input, OutputInterface $output)
{
$jobName = $input->getArgument('job');
$em = $this->getContainer()->get("doctrine.orm.entity_manager");
$em = $this->getContainer()->get('doctrine')
->getManager($this->getContainer()->getParameter('colour_stream_cron.entitymanger'));
$jobRepo = $em->getRepository('ColourStreamCronBundle:CronJob');

$job = $jobRepo->findOneByCommand($jobName);
Expand Down
3 changes: 2 additions & 1 deletion Command/CronEnableJobCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ protected function configure()
protected function execute(InputInterface $input, OutputInterface $output)
{
$jobName = $input->getArgument('job');
$em = $this->getContainer()->get("doctrine.orm.entity_manager");
$em = $this->getContainer()->get('doctrine')
->getManager($this->getContainer()->getParameter('colour_stream_cron.entitymanger'));
$jobRepo = $em->getRepository('ColourStreamCronBundle:CronJob');

$job = $jobRepo->findOneByCommand($jobName);
Expand Down
3 changes: 2 additions & 1 deletion Command/CronPruneLogsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ protected function configure()

protected function execute(InputInterface $input, OutputInterface $output)
{
$em = $this->getContainer()->get("doctrine.orm.entity_manager");
$em = $this->getContainer()->get('doctrine')
->getManager($this->getContainer()->getParameter('colour_stream_cron.entitymanger'));
$job = $input->getArgument('job');

if($job)
Expand Down
3 changes: 2 additions & 1 deletion Command/CronRunCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ protected function configure()
protected function execute(InputInterface $input, OutputInterface $output)
{
$start = microtime(true);
$em = $this->getContainer()->get("doctrine.orm.entity_manager");
$em = $this->getContainer()->get('doctrine')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move all of this into base command class and create helper method to be used in all commands

we must have this else it becomes a nightmare of bad code

->getManager($this->getContainer()->getParameter('colour_stream_cron.entitymanger'));
$jobRepo = $em->getRepository('ColourStreamCronBundle:CronJob');

$jobsToRun = array();
Expand Down
3 changes: 2 additions & 1 deletion Command/CronScanCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
{
$keepDeleted = $input->getOption("keep-deleted");
$defaultDisabled = $input->getOption("default-disabled");
$em = $this->getContainer()->get('doctrine.orm.entity_manager');
$em = $this->getContainer()->get('doctrine')
->getManager($this->getContainer()->getParameter('colour_stream_cron.entitymanger'));

// Enumerate the known jobs
$jobRepo = $em->getRepository('ColourStreamCronBundle:CronJob');
Expand Down
3 changes: 2 additions & 1 deletion Command/CronStatusCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ protected function configure()

protected function execute(InputInterface $input, OutputInterface $output)
{
$em = $this->getContainer()->get('doctrine.orm.entity_manager');
$em = $this->getContainer()->get('doctrine')
->getManager($this->getContainer()->getParameter('colour_stream_cron.entitymanger'));
$output->writeln("Cron job statuses:");

$cronJobs = array();
Expand Down
2 changes: 2 additions & 0 deletions DependencyInjection/ColourStreamCronExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ public function load(array $configs, ContainerBuilder $container)
$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);

$container -> setParameter('colour_stream_cron.entitymanger', $config['entitymanger']);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entity_manager


$loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
$loader->load('services.xml');
}
Expand Down
6 changes: 6 additions & 0 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ public function getConfigTreeBuilder()
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('colour_stream_cron');

$rootNode
->children()
->scalarNode('entitymanger')->defaultValue('default')->end()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to entityManager

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or entity_manager

->end()
;

// Here you should define the parameters that are allowed to
// configure your bundle. See the documentation linked above for
// more information on that topic.
Expand Down