Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tests run as part of image build procedure. #44

Merged
merged 20 commits into from
Sep 22, 2024
Merged

make tests run as part of image build procedure. #44

merged 20 commits into from
Sep 22, 2024

Conversation

espenhgn
Copy link
Collaborator

@espenhgn espenhgn commented Sep 20, 2024 •
edited
Loading

Fixes #40
Fixes #43
Fixes #45

Changes proposed in this pull request:

  • Add separate action to build on PR
  • Revise build-push action to trigger on tags on the main brain
  • Run unit tests to check container build
  • Bump some package versions

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@espenhgn espenhgn added the enhancement New feature or request label Sep 20, 2024
@espenhgn espenhgn merged commit 48cd943 into main Sep 22, 2024
7 checks passed
@espenhgn espenhgn deleted the espenhgn/issue40 branch September 22, 2024 09:48
@espenhgn espenhgn mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@espenhgn