Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BrowserList configuration and usage. Closes #108 #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update BrowserList configuration and usage. Closes #108 #109

wants to merge 2 commits into from

Conversation

peterblazejewicz
Copy link
Contributor

  • single place of configuration via .browserlistrc file
  • up-to-date configuration aligned with @angular/cli generated one

Thanks!

phra
phra requested changes May 28, 2019
View reviewed changes
.browserslistrc Outdated
last 2 versions
Firefox ESR
not dead
IE 10-11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the distinction between the envs and leave a lightweight configuration for the devs. also, i would suggest to drop IE 10 from the list.

Copy link
Contributor Author

@peterblazejewicz peterblazejewicz May 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest to drop IE 10 from the list.

That part is done via update

@peterblazejewicz
Update BrowserList configuration and usage. Closes preboot#108
f26ae18 
- single place of configuration via .browserlistrc file
- up-to-date configuration aligned with @angular/cli generated one

Thanks!
@peterblazejewicz
Drop IE 10 from Browserlist
5aed461
phra
phra reviewed May 28, 2019
View reviewed changes
.browserslistrc
> 0.5%
last 2 versions
Firefox ESR
not dead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't find the coverage of not dead: https://browserl.ist/?q=not+dead
instead i can see the others, eg. https://browserl.ist/?q=%3E+0.5%25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phra phra phra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterblazejewicz @phra