Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Kueez #4038

Merged
merged 5 commits into from
Jan 16, 2025
Merged

New Adapter: Kueez #4038

merged 5 commits into from
Jan 16, 2025

Conversation

saar120
Copy link
Contributor

@saar120 saar120 commented Nov 5, 2024

Copy link

github-actions bot commented Nov 5, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bf7ab42

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:30:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:80:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:123:	extractCid		71.4%
total:									(statements)		84.0%

@SyntaxNode SyntaxNode changed the title Kueez RTB adapter New Adapter: Kueez Nov 5, 2024
@@ -0,0 +1,20 @@
endpoint: "https://prebidsrvr.kueezrtb.com/openrtb/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint doesnt work
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemkaczmarek
You need to add the cId to the request

requestData := &adapters.RequestData{
Method: "POST",
Uri: fmt.Sprintf("%s%s", a.endpoint, url.QueryEscape(cId)),
Body: requestJSON,
Headers: headers,
ImpIDs: []string{imp.ID},
}
requests = append(requests, requestData)

CleanShot 2024-11-19 at 11 51 03

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemkaczmarek
Can we approve please?

Copy link
Collaborator

@przemkaczmarek przemkaczmarek Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint works
image

userSync:
iframe:
url: https://sync.kueezrtb.com/api/user/html/62ce79e7dd15099534ae5e04?pbs=true&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}
userMacro: ${userId}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works
image

@przemkaczmarek przemkaczmarek self-assigned this Nov 25, 2024
}

var invalidParams = []string{
`{"cId": 3898334}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happend if You add:
var invalidParams = []string{
{},
{"cId": 123},
{"cId": true},
{"cId": null},
{"cId": ""},
{"cId": " "},
{"cId": "cid_with_invalid_chars!@#"},
{"cId": "valid_cid", "extra_field": "unexpected"},
{"cId": "a_very_long_connection_id_exceeding_the_maximum_allowed_length_..."},
[],
["cId"],
"string_value",
42,
true,
{"cId": "valid_cid",
{"cId":},
{"cid": "valid_cid"},
}
please add more invalidParams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more..

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b76086d

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:30:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:68:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:111:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:124:	getMediaTypeForBid	100.0%
total:									(statements)		84.0%

@bsardo
Copy link
Collaborator

bsardo commented Nov 26, 2024

Hi @saar120, we noticed that your adapter is basically the same as the Vidazoo adapter. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

@saar120
Copy link
Contributor Author

saar120 commented Nov 26, 2024

Hey @bsardo
We are providing the adapter and the server as a white label solution.
KueezRtb and Vidazoo are different entities and should not share the same adapter.
For now this solution does not fit our needs.

przemkaczmarek
przemkaczmarek previously approved these changes Nov 27, 2024
@assa-kariv
Copy link

@przemkaczmarek are we waiting for an additional approval? we would really appreciate if it could be included in the following release

@przemkaczmarek
Copy link
Collaborator

@assa-kariv In our policy, we require two approvals.

@assa-kariv
Copy link

@przemkaczmarek yeah I am aware of that thanks for tagging another approver

@saar120
Copy link
Contributor Author

saar120 commented Dec 15, 2024

@bsardo
Can you please help with a review?

@assa-kariv
Copy link

@bsardo @przemkaczmarek please assist here

@bsardo bsardo added the adapter label Jan 6, 2025
@assa-kariv
Copy link

@bsardo can you please update what is the approval status?

@bsardo bsardo assigned VeronikaSolovei9 and unassigned bsardo Jan 9, 2025
@VeronikaSolovei9
Copy link
Contributor

VeronikaSolovei9 commented Jan 10, 2025

New adapters must also open a PR against the Prebid Docs repository here: https://github.com/prebid/prebid.github.io/

Please see the User Documentation section of the new adapter developer guide.

Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Code looks good to me. I added a comment about optional optimization. Please also add a documentation PR.
Thank you!

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 31015d9

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:28:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:66:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:109:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:122:	getMediaTypeForBid	100.0%
total:									(statements)		84.0%

@saar120
Copy link
Contributor Author

saar120 commented Jan 14, 2025

@VeronikaSolovei9 @przemkaczmarek
Thank you.
Added in the docs that we support pbs (PR link in the description)
also implemented the suggested improvement

Copy link
Contributor

@VeronikaSolovei9 VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Approved

@bsardo bsardo merged commit 243c0f0 into prebid:master Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants