-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules: Carry context from incoming requests to hooks #4007
base: master
Are you sure you want to change the base?
Conversation
…coming request to the module hooks.
Fixes #3962 |
Hi @scr-oath, can you please merge with master and resolve conflicts? Thanks! |
DONE |
47f9583
to
f9bc46d
Compare
FWIW, marking draft - we're fighting with some mobile SDK crashes related to the piece that adds the full-request timeout stuff… essentially, SDK crashes if the passthrough exists and we have a hook to remove it, which doesn't run if the entire request times out - the fix was fairly straightforward but grows this to have This also has me thinking - that hooks should probably have some way of declaring that they are critical - as in - timeouts should be treated as reject (or whole-request timeout) |
We discussed this a fair bit in the Prebid Server backlog review and it seems there are other concerns/needs that may need some thought/discussion.
Therefore, It would seem that a writeup and review of a solution should be done before implementation and PR is completed, which I'll tackle in an issue and/or google doc. |
This change