Pass currency converter to modules #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What you have looks good. Seems that you still have to clean up some old tests to reflect your changes, and should have some new tests to make sure the new features work properly. |
|
refactored the current unit tests to cover all the required scenarios. Please review :)
|
VeronikaSolovei9
approved these changes
Nov 9, 2023
bsardo
changed the title
svamiftah
pushed a commit
to sovrn/prebid-server
that referenced
this pull request
Nov 21, 2023
SuprPhatAnon
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.