Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow to support major version release #3235

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

onkarvhanumante
Copy link
Contributor

Description:

  • PR updates release workflow to support major version release
  • PBS-GO skipped the v1.0.0 major release - Prebid Server 2.0 Release #3068
    • If the current tag is v0.x.x, the script sets the next release tag to v2.0.0
    • Otherwise, the script increments the major version by 1 and sets the minor and patch versions to zero. For example, v2.x.x will be incremented to v3.0.0

Testing:

Tested on fork repo - https://github.com/onkarvhanumante/prebid-server/actions/workflows/release.yml

Major:
major
Minor:
minor
Patch:
patch

Docker images were built based on release type
Screenshot 2023-10-18 170955

# PBS-GO skipped the v1.0.0 major release - https://github.com/prebid/prebid-server/issues/3068
# If the current tag is v0.x.x, the script sets the next release tag to v2.0.0
# Otherwise, the script increments the major version by 1 and sets the minor and patch versions to zero
# For example, v2.x.x will be incremented to v3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I wasn't thinking of the 1.0 skip. Thank you for taking that into account.

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SyntaxNode SyntaxNode merged commit bc77035 into master Oct 18, 2023
3 checks passed
@SyntaxNode SyntaxNode deleted the update-release-workflow branch November 17, 2023 22:13
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants