Make user.ext.prebid.buyeruids bidder name case insensitive #3152
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1816,7 +1816,9 @@ func (deps *endpointDeps) validateUser(req *openrtb_ext.RequestWrapper, aliases | |
| return append(errL, errors.New(`request.user.ext.prebid requires a "buyeruids" property with at least one ID defined. If none exist, then request.user.ext.prebid should not be defined.`)) | ||
| } | ||
| for bidderName := range prebid.BuyerUIDs { | ||
| normalizedCoreBidder, _ := openrtb_ext.NormalizeBidderName(bidderName) | ||
| coreBidder := normalizedCoreBidder.String() | ||
| if _, ok := deps.bidderMap[coreBidder]; !ok { | ||
|
There was a problem hiding this comment. Nitpick: in this PR here https://github.com/prebid/prebid-server/pull/3187/files#diff-785f5ab5ebde657757f3b3c34bf30a939782678d61bf1ea43f844c4f22a012d9R155:~:text=normalizeBidderName%20%20%20%20%20%20%20normalizeBidderName @SyntaxNode introduced a new function in endpoint deps. Other than this looks good, local testing looks good too. There was a problem hiding this comment. Thank you, Veronika! Updated it in 49a8d0e |
||
| if _, ok := aliases[bidderName]; !ok { | ||
| return append(errL, fmt.Errorf("request.user.ext.%s is neither a known bidder name nor an alias in request.ext.prebid.aliases", bidderName)) | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| { | ||
| "description": "Amp request where root.user.ext.prebid.buyeruids field makes use of alias defined in root.ext.prebid.aliases and request makes use of case sensitive bidder name", | ||
| "query": "tag_id=101", | ||
| "config": { | ||
| "mockBidders": [ | ||
| { | ||
| "bidderName": "appnexus", | ||
| "currency": "USD", | ||
| "price": 2 | ||
| } | ||
| ] | ||
| }, | ||
| "mockBidRequest": { | ||
| "id": "request-with-user-ext-obj", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [ | ||
| { | ||
| "id": "my-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 600 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "prebid": { | ||
| "bidder": { | ||
| "Appnexus": { | ||
| "placementId": 12883451 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "user": { | ||
| "ext": { | ||
| "prebid": { | ||
| "buyeruids": { | ||
| "unknown": "123" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "ext": { | ||
| "prebid": { | ||
| "aliases": { | ||
| "unknown": "Appnexus" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expectedAmpResponse": { | ||
| "targeting": { | ||
| "hb_bidder": "Appnexus", | ||
| "hb_bidder_Appnexus": "Appnexus", | ||
| "hb_cache_host": "www.pbcserver.com", | ||
| "hb_cache_host_Appnex": "www.pbcserver.com", | ||
| "hb_cache_id": "0", | ||
| "hb_cache_id_Appnexus": "0", | ||
| "hb_cache_path": "/pbcache/endpoint", | ||
| "hb_cache_path_Appnex": "/pbcache/endpoint", | ||
| "hb_pb": "2.00", | ||
| "hb_pb_Appnexus": "2.00" | ||
| }, | ||
| "ortb2": { | ||
| "ext": { | ||
| "warnings": { | ||
| "general": [ | ||
| { | ||
| "code": 10002, | ||
| "message": "debug turned off for account" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expectedReturnCode": 200 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| { | ||
| "description": "Amp request where root.user.ext.prebid.buyeruids field has camel case bidder name", | ||
| "query": "tag_id=101", | ||
| "config": { | ||
| "mockBidders": [ | ||
| { | ||
| "bidderName": "yahooAds", | ||
| "currency": "USD", | ||
| "price": 2 | ||
| } | ||
| ] | ||
| }, | ||
| "mockBidRequest": { | ||
| "id": "request-with-user-ext-obj", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [ | ||
| { | ||
| "id": "my-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 600 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "prebid": { | ||
| "bidder": { | ||
| "YahooAds": { | ||
| "placementId": 12883451 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "user": { | ||
| "ext": { | ||
| "prebid": { | ||
| "buyeruids": { | ||
| "YahooAds": "123" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expectedAmpResponse": { | ||
| "targeting": { | ||
| "hb_bidder": "YahooAds", | ||
| "hb_bidder_YahooAds": "YahooAds", | ||
| "hb_cache_host": "www.pbcserver.com", | ||
| "hb_cache_host_YahooA": "www.pbcserver.com", | ||
| "hb_cache_id": "0", | ||
| "hb_cache_id_YahooAds": "0", | ||
| "hb_cache_path": "/pbcache/endpoint", | ||
| "hb_cache_path_YahooA": "/pbcache/endpoint", | ||
| "hb_pb": "2.00", | ||
| "hb_pb_YahooAds": "2.00" | ||
| }, | ||
| "ortb2": { | ||
| "ext": { | ||
| "warnings": { | ||
| "general": [ | ||
| { | ||
| "code": 10002, | ||
| "message": "debug turned off for account" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expectedReturnCode": 200 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| { | ||
| "description": "Amp request where root.user.ext.prebid.buyeruids field has case insensitive bidder name", | ||
| "query": "tag_id=101", | ||
| "config": { | ||
| "mockBidders": [ | ||
| { | ||
| "bidderName": "appnexus", | ||
| "currency": "USD", | ||
| "price": 2 | ||
| } | ||
| ] | ||
| }, | ||
| "mockBidRequest": { | ||
| "id": "request-with-user-ext-obj", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [ | ||
| { | ||
| "id": "my-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 600 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "prebid": { | ||
| "bidder": { | ||
| "Appnexus": { | ||
| "placementId": 12883451 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "user": { | ||
| "ext": { | ||
| "prebid": { | ||
| "buyeruids": { | ||
| "Appnexus": "123" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expectedAmpResponse": { | ||
| "targeting": { | ||
| "hb_bidder": "Appnexus", | ||
| "hb_bidder_Appnexus": "Appnexus", | ||
| "hb_cache_host": "www.pbcserver.com", | ||
| "hb_cache_host_Appnex": "www.pbcserver.com", | ||
| "hb_cache_id": "0", | ||
| "hb_cache_id_Appnexus": "0", | ||
| "hb_cache_path": "/pbcache/endpoint", | ||
| "hb_cache_path_Appnex": "/pbcache/endpoint", | ||
| "hb_pb": "2.00", | ||
| "hb_pb_Appnexus": "2.00" | ||
| }, | ||
| "ortb2": { | ||
| "ext": { | ||
| "warnings": { | ||
| "general": [ | ||
| { | ||
| "code": 10002, | ||
| "message": "debug turned off for account" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "expectedReturnCode": 200 | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you have two test case files that you added for this PR. Would it mean that it also needs to be added in this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added it in 07427d6