Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Teads #3112

Merged
merged 5 commits into from
Oct 16, 2023
Merged

New Adapter: Teads #3112

merged 5 commits into from
Oct 16, 2023

Conversation

github-maxime-liege
Copy link
Contributor

@github-maxime-liege github-maxime-liege commented Sep 19, 2023 •
edited
Loading

🏷 Type of change

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

github-actions[bot]
github-actions bot reviewed Sep 19, 2023
View reviewed changes
adapters/teads/teads.go Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 19, 2023
View reviewed changes
adapters/teads/teads.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, eb1a213

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder			100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests		69.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject		64.7%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL	75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids		70.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:166:	getMediaTypeForImp	75.0%
total:								(statements)		71.8%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0256b2a

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder			100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests		69.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject		64.7%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL	75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids		70.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:166:	getMediaTypeForImp	75.0%
total:								(statements)		71.8%

@bretg
Copy link
Contributor

bretg commented Sep 19, 2023

docs PR prebid/prebid.github.io#4871

@bsardo bsardo changed the title Teads Adapter with Custom rendering handling New Adapter: Teads Sep 19, 2023
@prebid prebid deleted a comment from github-actions bot Sep 21, 2023
@prebid prebid deleted a comment from github-actions bot Sep 21, 2023
@prebid prebid deleted a comment from github-actions bot Sep 21, 2023
@prebid prebid deleted a comment from github-actions bot Sep 21, 2023
@prebid prebid deleted a comment from github-actions bot Sep 21, 2023
@onkarvhanumante
Copy link
Contributor

Code coverage summary

Note:

* Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors

* Coverage summary encompasses all commits leading up to the latest one, [0256b2a](https://github.com/prebid/prebid-server/commit/0256b2a58170f7fbc11262001db3c7ee752348c3)

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder			100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests		69.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject		64.7%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL	75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids		70.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:166:	getMediaTypeForImp	75.0%
total:								(statements)		71.8%

@github-maxime-liege should add supplementary json test. Refer appnexustest/supplemental as example for supplementary json test

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1dd7250

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			76.9%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			88.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids			84.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:163:	getTeadsRendererFromBidExt	62.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:181:	getMediaTypeForImp		83.3%
total:								(statements)			81.6%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e62a5c7

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			76.9%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			88.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:163:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:181:	getMediaTypeForImp		83.3%
total:								(statements)			85.5%

@github-maxime-liege github-maxime-liege force-pushed the create_teads_adapter branch 2 times, most recently from 7143a54 to 3ee64a7 Compare September 22, 2023 09:17
@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7143a54

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			76.9%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			88.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:163:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:181:	getMediaTypeForImp		83.3%
total:								(statements)			85.5%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3ee64a7

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			76.9%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			88.2%
github.com/prebid/prebid-server/adapters/teads/teads.go:102:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:122:	MakeBids			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:163:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:181:	getMediaTypeForImp		83.3%
total:								(statements)			85.5%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 439e4f1

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			84.6%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:107:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:127:	MakeBids			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:168:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:186:	getMediaTypeForImp		83.3%
total:								(statements)			87.2%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 664872b

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			84.6%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:107:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:127:	MakeBids			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:168:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:186:	getMediaTypeForImp		83.3%
total:								(statements)			87.2%

onkarvhanumante
onkarvhanumante reviewed Oct 4, 2023
View reviewed changes
adapters/teads/teads.go Outdated
return openrtb_ext.BidTypeBanner
}
}
return openrtb_ext.BidTypeBanner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should error out if received impID that does not have any match in imps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, i could not use pointers because go does not allow me so i returned bidType Banner with error. If you have any tips on that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could return openrtb_ext.BidType("") instead of openrtb_ext.BidTypeBanner

refer #3112 (comment)

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b72868f

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			84.6%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:107:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:127:	MakeBids			86.4%
github.com/prebid/prebid-server/adapters/teads/teads.go:172:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:190:	getMediaTypeForImp		83.3%
total:								(statements)			86.4%

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d732b4f

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			84.6%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:107:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:127:	MakeBids			86.4%
github.com/prebid/prebid-server/adapters/teads/teads.go:172:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:190:	getMediaTypeForImp		83.3%
total:								(statements)			86.4%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7847f0a

teads

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/teads/teads.go:20:	Builder				100.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:32:	MakeRequests			84.6%
github.com/prebid/prebid-server/adapters/teads/teads.go:65:	updateImpObject			89.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:107:	buildEndpointURL		75.0%
github.com/prebid/prebid-server/adapters/teads/teads.go:127:	MakeBids			90.9%
github.com/prebid/prebid-server/adapters/teads/teads.go:172:	getTeadsRendererFromBidExt	87.5%
github.com/prebid/prebid-server/adapters/teads/teads.go:190:	getMediaTypeForImp		100.0%
total:								(statements)			88.9%

onkarvhanumante
onkarvhanumante approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@onkarvhanumante onkarvhanumante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sonali-More-Xandr Sonali-More-Xandr merged commit 6f4bb59 into prebid:master Oct 16, 2023
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Oct 16, 2023
Closed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
@github-maxime-liege @svamiftah
New Adapter: Teads (prebid#3112)
ad3b415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@github-maxime-liege @bretg @onkarvhanumante @Sonali-More-Xandr