Adapter Name Case Insensitive: user.ext.prebid.buyeruids (#3152)

prebid · Oct 17, 2023 · b3e5d1d · b3e5d1d
1 parent 1384564
commit b3e5d1d
Show file tree

Hide file tree

Showing 7 changed files with 396 additions and 3 deletions.
diff --git a/endpoints/openrtb2/amp_auction_test.go b/endpoints/openrtb2/amp_auction_test.go
@@ -50,6 +50,9 @@ func TestGoodAmpRequests(t *testing.T) {
 				"imp-with-stored-resp.json",
 				"gdpr-no-consentstring.json",
 				"gdpr.json",
+				"buyeruids-case-insensitive.json",
+				"buyeruids-camel-case.json",
+				"aliased-buyeruids-case-insensitive.json",
 			},
 		},
 		{

diff --git a/endpoints/openrtb2/auction.go b/endpoints/openrtb2/auction.go
@@ -1817,7 +1817,9 @@ func (deps *endpointDeps) validateUser(req *openrtb_ext.RequestWrapper, aliases
 			return append(errL, errors.New(`request.user.ext.prebid requires a "buyeruids" property with at least one ID defined. If none exist, then request.user.ext.prebid should not be defined.`))
 		}
 		for bidderName := range prebid.BuyerUIDs {
-			if _, ok := deps.bidderMap[bidderName]; !ok {
+			normalizedCoreBidder, _ := deps.normalizeBidderName(bidderName)
+			coreBidder := normalizedCoreBidder.String()
+			if _, ok := deps.bidderMap[coreBidder]; !ok {
 				if _, ok := aliases[bidderName]; !ok {
 					return append(errL, fmt.Errorf("request.user.ext.%s is neither a known bidder name nor an alias in request.ext.prebid.aliases", bidderName))
 				}

diff --git a/.../openrtb2/sample-requests/amp/valid-supplementary/aliased-buyeruids-case-insensitive.json b/.../openrtb2/sample-requests/amp/valid-supplementary/aliased-buyeruids-case-insensitive.json
@@ -0,0 +1,84 @@
+{
+  "description": "Amp request where root.user.ext.prebid.buyeruids field makes use of alias defined in root.ext.prebid.aliases and request makes use of case sensitive bidder name",
+  "query": "tag_id=101",
+  "config": {
+    "mockBidders": [
+      {
+        "bidderName": "appnexus",
+        "currency": "USD",
+        "price": 2
+      }
+    ]
+  },
+  "mockBidRequest": {
+    "id": "request-with-user-ext-obj",
+    "site": {
+      "page": "test.somepage.com"
+    },
+    "imp": [
+      {
+        "id": "my-imp-id",
+        "banner": {
+          "format": [
+            {
+              "w": 300,
+              "h": 600
+            }
+          ]
+        },
+        "ext": {
+          "prebid": {
+            "bidder": {
+              "Appnexus": {
+                "placementId": 12883451
+              }
+            }
+          }
+        }
+      }
+    ],
+    "user": {
+      "ext": {
+        "prebid": {
+          "buyeruids": {
+            "unknown": "123"
+          }
+        }
+      }
+    },
+    "ext": {
+      "prebid": {
+        "aliases": {
+          "unknown": "Appnexus"
+        }
+      }
+    }
+  },
+  "expectedAmpResponse": {
+    "targeting": {
+      "hb_bidder": "Appnexus",
+      "hb_bidder_Appnexus": "Appnexus",
+      "hb_cache_host": "www.pbcserver.com",
+      "hb_cache_host_Appnex": "www.pbcserver.com",
+      "hb_cache_id": "0",
+      "hb_cache_id_Appnexus": "0",
+      "hb_cache_path": "/pbcache/endpoint",
+      "hb_cache_path_Appnex": "/pbcache/endpoint",
+      "hb_pb": "2.00",
+      "hb_pb_Appnexus": "2.00"
+    },
+    "ortb2": {
+      "ext": {
+        "warnings": {
+          "general": [
+            {
+              "code": 10002,
+              "message": "debug turned off for account"
+            }
+          ]
+        }
+      }
+    }
+  },
+  "expectedReturnCode": 200
+}
diff --git a/endpoints/openrtb2/sample-requests/amp/valid-supplementary/buyeruids-camel-case.json b/endpoints/openrtb2/sample-requests/amp/valid-supplementary/buyeruids-camel-case.json
@@ -0,0 +1,77 @@
+{
+  "description": "Amp request where root.user.ext.prebid.buyeruids field has camel case bidder name",
+  "query": "tag_id=101",
+  "config": {
+    "mockBidders": [
+      {
+        "bidderName": "yahooAds",
+        "currency": "USD",
+        "price": 2
+      }
+    ]
+  },
+  "mockBidRequest": {
+    "id": "request-with-user-ext-obj",
+    "site": {
+      "page": "test.somepage.com"
+    },
+    "imp": [
+      {
+        "id": "my-imp-id",
+        "banner": {
+          "format": [
+            {
+              "w": 300,
+              "h": 600
+            }
+          ]
+        },
+        "ext": {
+          "prebid": {
+            "bidder": {
+              "YahooAds": {
+                "placementId": 12883451
+              }
+            }
+          }
+        }
+      }
+    ],
+    "user": {
+      "ext": {
+        "prebid": {
+          "buyeruids": {
+            "YahooAds": "123"
+          }
+        }
+      }
+    }
+  },
+  "expectedAmpResponse": {
+    "targeting": {
+      "hb_bidder": "YahooAds",
+      "hb_bidder_YahooAds": "YahooAds",
+      "hb_cache_host": "www.pbcserver.com",
+      "hb_cache_host_YahooA": "www.pbcserver.com",
+      "hb_cache_id": "0",
+      "hb_cache_id_YahooAds": "0",
+      "hb_cache_path": "/pbcache/endpoint",
+      "hb_cache_path_YahooA": "/pbcache/endpoint",
+      "hb_pb": "2.00",
+      "hb_pb_YahooAds": "2.00"
+    },
+    "ortb2": {
+      "ext": {
+        "warnings": {
+          "general": [
+            {
+              "code": 10002,
+              "message": "debug turned off for account"
+            }
+          ]
+        }
+      }
+    }
+  },
+  "expectedReturnCode": 200
+}
diff --git a/endpoints/openrtb2/sample-requests/amp/valid-supplementary/buyeruids-case-insensitive.json b/endpoints/openrtb2/sample-requests/amp/valid-supplementary/buyeruids-case-insensitive.json
@@ -0,0 +1,77 @@
+{
+  "description": "Amp request where root.user.ext.prebid.buyeruids field has case insensitive bidder name",
+  "query": "tag_id=101",
+  "config": {
+    "mockBidders": [
+      {
+        "bidderName": "appnexus",
+        "currency": "USD",
+        "price": 2
+      }
+    ]
+  },
+  "mockBidRequest": {
+    "id": "request-with-user-ext-obj",
+    "site": {
+      "page": "test.somepage.com"
+    },
+    "imp": [
+      {
+        "id": "my-imp-id",
+        "banner": {
+          "format": [
+            {
+              "w": 300,
+              "h": 600
+            }
+          ]
+        },
+        "ext": {
+          "prebid": {
+            "bidder": {
+              "Appnexus": {
+                "placementId": 12883451
+              }
+            }
+          }
+        }
+      }
+    ],
+    "user": {
+      "ext": {
+        "prebid": {
+          "buyeruids": {
+            "Appnexus": "123"
+          }
+        }
+      }
+    }
+  },
+  "expectedAmpResponse": {
+    "targeting": {
+      "hb_bidder": "Appnexus",
+      "hb_bidder_Appnexus": "Appnexus",
+      "hb_cache_host": "www.pbcserver.com",
+      "hb_cache_host_Appnex": "www.pbcserver.com",
+      "hb_cache_id": "0",
+      "hb_cache_id_Appnexus": "0",
+      "hb_cache_path": "/pbcache/endpoint",
+      "hb_cache_path_Appnex": "/pbcache/endpoint",
+      "hb_pb": "2.00",
+      "hb_pb_Appnexus": "2.00"
+    },
+    "ortb2": {
+      "ext": {
+        "warnings": {
+          "general": [
+            {
+              "code": 10002,
+              "message": "debug turned off for account"
+            }
+          ]
+        }
+      }
+    }
+  },
+  "expectedReturnCode": 200
+}