Exitpoint Stage #3564
Merged
Exitpoint Stage #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You missed |
Net-burst
reviewed
Nov 22, 2024
src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Dec 2, 2024
src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java
Outdated
Show resolved
Hide resolved
| final Endpoint endpoint = context.getEndpoint(); | ||
|
|
||
| return stageExecutor(StageWithHookType.EXITPOINT, ENTITY_HTTP_RESPONSE, context, account, endpoint) | ||
| .withInitialPayload(ExitpointPayloadImpl.of(responseHeaders, responseBody)) |
There was a problem hiding this comment.
Perhaps we need to wrap responseHeaders in an unmodifiable implementation. @And1sS what do you think?
There was a problem hiding this comment.
do you mean we want to make module to recreate the full map instead of updating what is passed? it will be an additional step for the module creators
src/main/java/org/prebid/server/proto/openrtb/ext/response/ExtTraceActivityInfrastructure.java
Outdated
Show resolved
Hide resolved
And1sS
previously approved these changes
Dec 3, 2024
CTMBNara
previously approved these changes
Dec 3, 2024
# Conflicts: # src/test/java/org/prebid/server/hooks/execution/HookStageExecutorTest.java
osulzhenko
approved these changes
Dec 4, 2024
sergseven
pushed a commit
to openx/prebid-server-java
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
prebid/prebid-server#4044
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check