IX: fix ix adapter handling of paapi config #3563
Conversation
| @Test | ||
| public void openrtb2AuctionShouldRespondWithBidsFromIxForPrivacySandboxRequest() throws IOException, JSONException { | ||
| // given | ||
| WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/ix-exchange")) | ||
| .withRequestBody(equalToJson(jsonFrom("openrtb2/ix/privacy-sandbox-test-ix-bid-request.json", | ||
| prebidVersionProvider))) | ||
| .willReturn(aResponse().withBody(jsonFrom("openrtb2/ix/privacy-sandbox-test-ix-bid-response.json")))); | ||
|
|
||
| // when | ||
| final Response response = responseFor("openrtb2/ix/privacy-sandbox-test-auction-ix-request.json", | ||
| Endpoint.openrtb2_auction); | ||
|
|
||
| // then | ||
| assertJsonEquals("openrtb2/ix/privacy-sandbox-test-auction-ix-response.json", response, singletonList("ix")); | ||
| } |
There was a problem hiding this comment.
do not need to create a separate integration test and a separate set of the json files, just use your json files for the existing test
There was a problem hiding this comment.
Do you mean keeping only the Privacy Sandbox scenario test and deleting the regular one? I’d say having both makes sense, as the intention behind these two tests is different—one tests the Privacy Sandbox request scenario, while the other covers a regular (non-Privacy Sandbox) case.
There was a problem hiding this comment.
Our integration tests are mainly for the bidder configuration verification. But, since your test case extends the regular one, I suggest using yours payloads instead. So please replace existing JSON payloads with yours.
🔧 Type of changes
✨ What's the context?
This is the fix of paapi auction config handling for IX Adapter as described in #3562
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
This change aligns with how Index Exchange formats the auction configuration for the PAAPI response.
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check