Arbitrary ORTB request configuration changes #1064
Conversation
| super.init() | ||
| } | ||
|
|
||
| public static func enrich( |
There was a problem hiding this comment.
Let's change the signature of this method due to it's resposibility.
public static func merge(
sdkORTB: [String: Any],
globalORTB: String?,
impORTB: String?
) -> [String: Any] {
///
|
|
||
| if var globalORTBDict = ArbitraryGlobalORTBHelper(ortb: globalORTB).getValidatedORTBDict() { | ||
| let existingImpDict = resultORTB["imp"] as? [[String: Any]] | ||
| resultORTB["imp"] = nil |
There was a problem hiding this comment.
Can we make this function better?
In line 35, we added the "imp" object. In line 40, we are removing it.
I believe the algorithm can be more convenient.
|
|
||
| struct ProtectedFields { | ||
|
|
||
| static var deviceProps: [String] { |
There was a problem hiding this comment.
I'm just curious: why is it var?
Because of this: https://forums.swift.org/t/static-var-vs-static-let/59215 ?
| resultORTB["imp"] = existingImps?.map { $0.deepMerging(with: impORTBDict) } ?? [impORTBDict] | ||
| } | ||
|
|
||
| if var globalORTBDict = ArbitraryGlobalORTBHelper(ortb: globalORTB).getValidatedORTBDict() { |
There was a problem hiding this comment.
Does it make sense to apply getValidatedORTBDict only once when the publisher sets the respective property?
| XCTAssertNil(result) | ||
| } | ||
|
|
||
| func testGlobalORTBHelper_ValidJSON_RemoveProtectedFields() { |
There was a problem hiding this comment.
We also need some tests that checks the correct work and combinations of setGlobalORTBConfig and setImpressionORTBConfig.
It's ok if it will be integration tests.
#1017