Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

priceFloors & PBS adapter: support mediaType and size specific floors #12690

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

priceFloors & PBS adapter: support mediaType and size specific floors #12690

wants to merge 4 commits into from
+434 −209

Conversation

dgirardi
Copy link
Collaborator

@dgirardi dgirardi commented Jan 23, 2025 •
edited
Loading

Type of change

  • Feature

Description of change

  • Updated priceFloors to pass a 3rd argument {size, mediaType} to inverseCpmAdjustment
  • Updated ORTB converter to ask for specific floors for each mediatype and banner size. If these are different from imp.bidfloor, they're set to ext.bidfloor & ext.bidfloorcur under native/video/banner and each format in banner.format.
  • Updated the PBS adapter to aggregate granular floors in a similar way to imp.bidfloor (in case floors are different across bidders).

Other information

Closes #12308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez Awaiting requested review from robertrmartinez

@mmoschovas mmoschovas Awaiting requested review from mmoschovas

At least 1 approving review is required to merge this pull request.

Assignees

@robertrmartinez robertrmartinez

@mmoschovas mmoschovas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imp level floors on multiformat units
3 participants
@dgirardi @robertrmartinez @mmoschovas