Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidderSettings: Allow Currency Code control through adjustCurrency #12645

Closed
wants to merge 14 commits into from
Closed

bidderSettings: Allow Currency Code control through adjustCurrency #12645

Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bf59478
Getting whole bid from bidcpmadjustment function and then equalizing …
Jan 13, 2025
ea182c0
Setting the bidCurrency to adServerCurrency for people using bidcpmad…
Jan 13, 2025
7c01d90
Setting the bidCurrency to adServerCurrency for people using bidcpmad…
Jan 13, 2025
99e8e72
Adjusted adservercurrency retrieval for currency code conversion corr…
Jan 13, 2025
54b91a1
Resolving bidpriceadjusted error and requesting a review again
Jan 14, 2025
5a356e8
pbjs error resolved
Jan 14, 2025
ca1664b
declared pbjs to rectify error
Jan 14, 2025
8bc3d3b
Tried resolving lint error
Jan 14, 2025
24faedd
lint error resolve
Jan 14, 2025
761a13c
lint error resolve
Jan 14, 2025
6857db3
lint error resolve
Jan 14, 2025
67b78fe
Fixed pbjs not defined linting error
Jan 14, 2025
722e054
Added currency code adjustment as optional and created unit test
Jan 15, 2025
e32c56b
Clear lint
Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/auction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,8 +910,9 @@ function setKeys(keyValues, bidderSettings, custBidObj, bidReq) {
export function adjustBids(bid) {
let bidPriceAdjusted = adjustCpm(bid.cpm, bid);

if (bidPriceAdjusted >= 0) {
if (bidPriceAdjusted.cpm >= 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests right now are failing because of linting errors, however, I hope they'd fail on this as well. bidPriceAdjusted is the adjusted CPM, on its own this cannot make sense.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgirardi Kindly check it out again as I reverted bidPriceAdjusted as it was before. Now just fetching the adServerCurrency here for the currency code update

bid.cpm = bidPriceAdjusted;
bid.currency = $$PREBID_GLOBAL$$.getConfig('currency').adServerCurrency;
}
}

Expand Down
Loading