Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondorX Bid Adapter : initial release #12643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CondorXIO
Copy link

Type of change

  • New bidder adapter

Description of change

Add CondorX Bid Adapter

contact email: [email protected]

test params:

{
  bidder: 'condorx',
  params: {
    website: 195491,
    widget: 274572,
    url: 'current url'
  }
}

@ChrisHuie ChrisHuie changed the title Add CondorX Bid Adapter CondorX Bid Adapter : initial release Jan 13, 2025
@ChrisHuie ChrisHuie requested a review from Rothalack January 13, 2025 19:42
@Rothalack
Copy link
Collaborator

You'll need to get a docs PR up on the docs site as well

https://github.com/prebid/prebid.github.io/pulls

@Rothalack
Copy link
Collaborator

It's pretty difficult to diagnose what's happening from this side of things when testing. I expect to be able to test your bidder with the simple hello_world set up and I've only seen errors back from your server. I assume there's some issues to solve on your server side. For example, it seems no matter what I try, this is always seeing null.

Access to fetch at 'https://api.condorx.io/cxb/get.json?w=195491&wg=274572&u=http://127.0.0.1:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true&p=0&ireqid=34a533c817ba54&prebid=1&imgw=236&imgh=202' from origin 'http://127.0.0.1:9999' has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header has a value 'null' that is not equal to the supplied origin. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

GET https://api.condorx.io/cxb/get.json?w=195491&wg=274572&u=http://127.0.0.1:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true&p=0&ireqid=34a533c817ba54&prebid=1&imgw=236&imgh=202 net::ERR_FAILED 200 (OK)

Prebid condorx ERROR: Server call for condorx failed: 0. Continuing without bids.

This was a test where I removed the url param from the bidder params, so it pulled the full url for the url param in the api call. But it still finds null when looking for Access, regardless of the url param and what it is set to.

I was testing with these params and a native adunit
website: 195491,
widget: 274572,
If you have a different set of params to test with, let me know.

@CondorXIO
Copy link
Author

CondorXIO commented Jan 14, 2025

@Rothalack thank you very much for your prompt review. I am checking the issue you raised and updating soon.

prebid docs PR:

prebid/prebid.github.io#5818

@CondorXIO
Copy link
Author

CondorXIO commented Jan 14, 2025

@Rothalack please check now hello_world.html, you should get results, everything is working as expected.
this is what I ran:

// Replace this object to test a new Adapter!
            bids: [{
                bidder: 'condorx',
                params: {
                    widget: 274572,
                    website: 195491
                }
            }]

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants