Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay detection update: ignore NotSupportedError exceptions #12603

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Autoplay detection update: ignore NotSupportedError exceptions #12603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574e97f
Ignore NotSupportedError exceptions in autoplay detection
github-matthieu-wipliez Dec 23, 2024
dddd8d5
Remove warning that has been addressed by #11822
github-matthieu-wipliez Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions libraries/autoplayDetection/autoplay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
let autoplayEnabled = null;

/**
* DEVELOPER WARNING: IMPORTING THIS LIBRARY MAY MAKE YOUR ADAPTER NO LONGER COMPATIBLE WITH APP PUBLISHERS USING WKWEBVIEW
* Note: this function returns true if detection is not done yet. This is by design: if autoplay is not allowed,
* the call to video.play() will fail immediately, otherwise it may not terminate.
* @returns true if autoplay is not forbidden
Expand Down Expand Up @@ -41,8 +40,12 @@ function startDetection() {
// if the video is played on a WebView with playsinline = false, this stops the video, to prevent it from being displayed fullscreen
videoElement.src = '';
})
.catch(() => {
autoplayEnabled = false;
.catch((error) => {
if (error instanceof DOMException && error.name === 'NotSupportedError') {
// ignore this error caused by a Content Security Policy that disables data: scheme for media URLs
} else {
autoplayEnabled = false;
}
});
}

Expand Down
Loading