Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retailspot bidAdapter : Endpoint update #12602

Merged
merged 7 commits into from
Dec 26, 2024

Conversation

rs-guian
Copy link
Contributor

Type of change

  • [*] Updated bidder adapter

Does this change affect user-facing APIs or examples documented on http://prebid.org?
No

Description of change

Our endpoint for incoming header bidding trafic has been changed. Update the bidder adapter accordingly.
Test parameters and unit tests have been updated too.

Other information

This is an official bid adapter release from RetailSpot.
See our format on this demo page.

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • modules/retailspotBidAdapter.js (+4 errors)

@rs-guian
Copy link
Contributor Author

Seems like the failing test is not related the the PR changes:

Chunk 1 of 1 failed: From test/spec/AnalyticsAdapter_spec.js to test/spec/video_spec.js

@patmmccann patmmccann changed the title Update Retailspot bidAdapter Endpoint Retailspot bidAdapter : Endpoint update Dec 26, 2024
@patmmccann patmmccann self-requested a review December 26, 2024 16:57
@patmmccann patmmccann self-assigned this Dec 26, 2024
@patmmccann patmmccann merged commit 0419f1a into prebid:master Dec 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants