Core: Local cache for video bids #12598
Conversation
| vastsLocalCache.set(getLocalCacheBidId(bid), dataUri); | ||
| }; | ||
|
|
||
| export async function getLocalCachedBidWithGam(adTagUrl) { |
There was a problem hiding this comment.
This should be in the dfp module.
IMO the GAM flow in general needs to change, instead of calling dfp's buildVideoUrl and passing the URL to the player it should be something like getVast and pass the XML to the player, which should work regardless of whether one is using local cache, and should also be the same thing that's called by the video module (regardless of the type of cache in use).
It might help to update / add a non-video module example to flesh out how the new API should look.
|
|
||
| const gamVastWrapper = await response.text(); | ||
| const bidVastDataUri = vastsLocalCache.get(`${hb_bidder}_${hb_adid}`); | ||
| const mockUrl = LOCAL_CACHE_MOCK_URL + hb_bidder; |
There was a problem hiding this comment.
the "normal" cache generates a UUID which is then passed on to the creative and echoed back in the VAST.
I think the local cache could also generate a UUID, pass it along in the same way, and this could look for it in the response contents instead of imposing a different URL structure in the creative. It'd have the advantage of working with existing integrations, and being easier to switch into / out of.
Type of change
Description of change
Other information