Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adtrgtme: Change #12539

Closed
wants to merge 7 commits into from
Closed

Adtrgtme: Change #12539

wants to merge 7 commits into from

Conversation

tarasmatokhniuk
Copy link
Contributor

Type of change

  • Bugfix
  • Updated bidder adapter

Description of change

  • Adapter and server mismatch. Use string to set up site.id
  • Add optional adapter fields. Added strict placement identification and currency

@patmmccann
Copy link
Collaborator

patmmccann commented Dec 10, 2024

@tarasmatokhniuk had you noticed the extensive duplication with Yahoo? This pr appears to somehow break the duplication check. Perhaps the conflicts need to be resolved?

@tarasmatokhniuk
Copy link
Contributor Author

@patmmccann thank you for your time on my commit. Сould you tell me why there is no mention of the adtrgtmeBidAdapter adapter in the raw action check logs or in the check-duplication report unfiltered-jscpd-report
But the check still fails. Should I indicate somewhere that the check is only for adtrgtmeBidAdapter?

"/home/runner/work/Prebid.js/Prebid.js/modules/adtrgtmeBidAdapter.js": {
            "lines": 359,
            "tokens": 3072,
            "sources": 1,
            "clones": 0,
            "duplicatedLines": 0,
            "duplicatedTokens": 0,
            "percentage": 0,
            "percentageTokens": 0,
            "newDuplicatedLines": 0,
            "newClones": 0
          },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants