Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit MadSense Adapter #12501

Closed
wants to merge 12 commits into from
Closed

Conversation

madsenseops
Copy link
Contributor

Type of change

  • [x ] New bidder adapter

Description of change

New Bidder Adapter

  • contact email: [email protected]
  • test parameters for validating bids: Use provided _spec files

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+3 errors)

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+3 errors)

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+3 errors)

Copy link

github-actions bot commented Dec 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Dec 2, 2024

Tread carefully! This PR adds 7 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+7 errors)

Copy link

github-actions bot commented Dec 2, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Dec 2, 2024

Tread carefully! This PR adds 17 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+17 errors)

Copy link

github-actions bot commented Dec 3, 2024

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+3 errors)

Copy link

github-actions bot commented Dec 3, 2024

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+3 errors)

Copy link

github-actions bot commented Dec 3, 2024

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/madsenseBidAdapter.js (+1 error)

@madsenseops madsenseops closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant