Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criteo Bid Adapter: allow to specify tagid in params #12490

Closed
wants to merge 2 commits into from

Conversation

ptomasroos
Copy link
Contributor

Type of change

  • Feature

Description of change

We use the networkId and not zoneId's. But there are still cases where we are constrained by the requirement to have a fully matching adUnitCode to get the tagid set.

All other adapters support to explicit set placement, id, ect I think its extremely useful to be able to continue to use the network id approach but still specify the adUnitCode or tagid which is the internal name for the same mapping

@acomets
Copy link

acomets commented Nov 26, 2024

Hi @ptomasroos, why can you not use the adUnitCode that is already mapped to tagid?

If not, we can look into adding tagid, but it may be cleaner to add it via ortb2 with something like

imp.tagid = deepAccess(bidRequest, 'ortb2Imp.tagid') || bidRequest.adUnitCode;

@ptomasroos
Copy link
Contributor Author

@acomets Thanks for the feedback.

The reason is because the same adUnitCode could have different bidder configurations depending on key values on our side, and reusing them and adding the same adUnitCode over and over again makes it very hard to track which adUnitCode is request later down in the requestBids.

We could have a section where native is enabled, but not on the first the same adUnitCode since they are virtually the same placement but not at runtime. All bidders except criteo supports to explicitly set the placement id which is why I think it makes sense to resolve this issue for us at least.

Moving back to the zone id's feels cumbersome given multi ad size support

@acomets
Copy link

acomets commented Nov 26, 2024

Thanks @ptomasroos, and would it be okay for you to use ortb2 to pass us tagid via ortb2Imp.tagid?

@ptomasroos
Copy link
Contributor Author

ptomasroos commented Nov 27, 2024

@acomets Of course. I see no issues with that!
Do you want me to update the PR?

@ptomasroos
Copy link
Contributor Author

Friendly reminder @acomets

@ChrisHuie ChrisHuie self-requested a review December 6, 2024 11:21
@ChrisHuie ChrisHuie self-assigned this Dec 6, 2024
@ChrisHuie ChrisHuie changed the title criteoBidAdapter: allow to specify tagid in params criteo Bid Adapter: allow to specify tagid in params Dec 6, 2024
@acomets
Copy link

acomets commented Dec 6, 2024

Hi @ptomasroos, sorry for the delay in response.

Sure if you don't mind feel free to update the PR directly, that would be great!

Thanks

@ptomasroos
Copy link
Contributor Author

NP, fixed @acomets

@ptomasroos ptomasroos closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants