criteo Bid Adapter: allow to specify tagid in params #12490
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We use the networkId and not zoneId's. But there are still cases where we are constrained by the requirement to have a fully matching adUnitCode to get the tagid set.
All other adapters support to explicit set placement, id, ect I think its extremely useful to be able to continue to use the network id approach but still specify the adUnitCode or tagid which is the internal name for the same mapping