ImRtdProvider: add imuid param #12475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
requested changes
Nov 21, 2024
modules/imRtdProvider.js
Outdated
| @@ -80,7 +80,25 @@ export function getBidderFunction(bidderName) { | |||
| ); | |||
| } | |||
| return bid | |||
| } | |||
| }, | |||
| craft: function (bid, data, moduleConfig) { | |||
There was a problem hiding this comment.
the special handling for craft, pubmatic, and fluct should all be in those modules. see #8596
There was a problem hiding this comment.
@patmmccann
I removed the settings for 'craft' that I had added and changed it to only add the imuid parameter.
The previous support will not be removed this time for backward compatibility.
5434fa9
eknis
changed the title
|
@patmmccann |
patmmccann
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information