Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missena Bid Adapter : add session tracking, update referer & location fields #11764

Closed
wants to merge 6 commits into from

Conversation

pdamoc
Copy link
Contributor

@pdamoc pdamoc commented Jun 11, 2024

Type of change

  • Feature

Description of change

This PR implements session tracking logic and restructures the referer related fields.

Other information

@ysfbsf is responsible for the implementation.

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • modules/missenaBidAdapter.js has 9 duplicated lines with modules/themoneytizerBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@ChrisHuie ChrisHuie changed the title Missena Bid Adapter: Add session tracking and update referer & location fields Missena Bid Adapter : add session tracking, update referer & location fields Jun 12, 2024
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • modules/missenaBidAdapter.js has 9 duplicated lines with modules/themoneytizerBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

if (bidRequest.params.formats) {
payload.formats = bidRequest.params.formats;
if (bidParams.formats) {
payload.formats = bidParams.formats;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you are just changing variable names to avoid the detection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we avoid triggering duplication errors in this case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should import common functions from a library

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator

It appears your commits have intended to fool the duplication check instead of fixing the underlying issue.

@patmmccann
Copy link
Collaborator

Also please note jsdoc issues:

/home/circleci/Prebid.js/modules/missenaBidAdapter.js
65:0 warning Syntax error in namepath: - jsdoc/valid-types
65:0 warning Expected @param names to be "validBidRequests, bidderRequest". Got "-" jsdoc/check-param-names
173:0 warning The type 'data' is undefined jsdoc/no-undefined-types
173:0 warning Expected @param names to be "timeoutData". Got "Containing" jsdoc/check-param-names
181:0 warning Expected @param names to be "bid". Got "The" jsdoc/check-param-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants