Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code dupe test #11758

Closed
wants to merge 1 commit into from
Closed

Code dupe test #11758

wants to merge 1 commit into from

Conversation

patmmccann
Copy link
Collaborator

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

  • modules/vidoomyBidAdapter.js has 9 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/smarthubBidAdapter.js has 16 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/smarthubBidAdapter.js has 11 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/smarthubBidAdapter.js has 6 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/smarthubBidAdapter.js has 14 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/smarthubBidAdapter.js has 18 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/smarthubBidAdapter.js has 17 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/redtramBidAdapter.js has 46 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/qtBidAdapter.js has 21 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/qtBidAdapter.js has 31 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/qtBidAdapter.js has 15 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/qtBidAdapter.js has 74 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/qtBidAdapter.js has 28 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/qtBidAdapter.js has 17 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pubCircleBidAdapter.js has 23 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pubCircleBidAdapter.js has 50 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pubCircleBidAdapter.js has 11 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pubCircleBidAdapter.js has 40 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pubCircleBidAdapter.js has 82 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/playdigoBidAdapter.js has 69 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/playdigoBidAdapter.js has 78 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pgamsspBidAdapter.js has 29 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/pgamsspBidAdapter.js has 128 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mobfoxpbBidAdapter.js has 12 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mobfoxpbBidAdapter.js has 15 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mgidXBidAdapter.js has 93 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mgidXBidAdapter.js has 88 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mgidXBidAdapter.js has 21 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mathildeadsBidAdapter.js has 24 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mathildeadsBidAdapter.js has 20 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mathildeadsBidAdapter.js has 28 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mathildeadsBidAdapter.js has 12 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mathildeadsBidAdapter.js has 25 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/mathildeadsBidAdapter.js has 81 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/lunamediahbBidAdapter.js has 12 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/lunamediahbBidAdapter.js has 31 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/loyalBidAdapter.js has 33 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/loyalBidAdapter.js has 40 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/krushmediaBidAdapter.js has 40 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/krushmediaBidAdapter.js has 11 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/kiviadsBidAdapter.js has 145 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/kiviadsBidAdapter.js has 54 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/iqzoneBidAdapter.js has 231 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/globalsunBidAdapter.js has 203 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/emtvBidAdapter.js has 148 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/emtvBidAdapter.js has 54 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/edge226BidAdapter.js has 180 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/e_volutionBidAdapter.js has 23 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/e_volutionBidAdapter.js has 59 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/contentexchangeBidAdapter.js has 16 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/contentexchangeBidAdapter.js has 26 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/contentexchangeBidAdapter.js has 32 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/contentexchangeBidAdapter.js has 72 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/compassBidAdapter.js has 203 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/colossussspBidAdapter.js has 14 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/colossussspBidAdapter.js has 8 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/colossussspBidAdapter.js has 9 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/colossussspBidAdapter.js has 23 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/boldwinBidAdapter.js has 14 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/boldwinBidAdapter.js has 16 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/boldwinBidAdapter.js has 24 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/beyondmediaBidAdapter.js has 35 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/axisBidAdapter.js has 23 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/axisBidAdapter.js has 17 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/axisBidAdapter.js has 28 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/axisBidAdapter.js has 12 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/axisBidAdapter.js has 41 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/axisBidAdapter.js has 14 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/appushBidAdapter.js has 180 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/adprimeBidAdapter.js has 20 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/admanBidAdapter.js has 19 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/admanBidAdapter.js has 24 duplicated lines with modules/visiblemeasuresBidAdapter.js
  • modules/acuityadsBidAdapter.js has 147 duplicated lines with modules/visiblemeasuresBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant