SeedingAlliance Bid Adapter: internal rework to send OpenRTB native compliant requests to backend #11746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems you have several duplicated code blocks |
|
The change is only in two files, nowhere near where the report says. I'm unsure what the problem seems to be. Any advice on how to handle this? |
|
If you pull in master it should make a pretty comment flagging the blocks now. The idea is to simply move the duplicated code to a common location and to import it in both places it is used |
|
If your goal is to make ortb2 bid requests, why still use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Due to work on the backend, we need clients to send properly formatted OpenRTB Native requests, as well as understand the response. This change assures that. Compability on the backend is ensured.
Other information