PBjs Utils: Faster Deep Clone #11418
Merged
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaresic
commented
Apr 29, 2024
| @@ -57,7 +57,7 @@ export function addBrowsiTag(data) { | |||
| script.setAttribute('prebidbpt', 'true'); | |||
| script.setAttribute('id', 'browsi-tag'); | |||
| script.setAttribute('src', data.u); | |||
| script.prebidData = deepClone(data); | |||
| script.prebidData = deepClone(typeof data === 'string' ? Object(data) : data) | |||
There was a problem hiding this comment.
Version 1 of just-clone casts everything to an object, even though in this case it was a string (I am not sure if this was wanted behavior, but it resulted in a failed test).
The newer versions don't do that, just like klona.
This is here to preserve that behavior.
bbaresic
commented
Apr 29, 2024
| @@ -609,7 +609,7 @@ export function shuffle(array) { | |||
| } | |||
|
|
|||
| export function deepClone(obj) { | |||
| return clone(obj); | |||
| return klona(obj) || {}; | |||
There was a problem hiding this comment.
Version 1 of just-clone gives back an empty object when the cloning fails.
The newer versions don't do that, just like klona.
This is here to preserve that behavior.
patmmccann
approved these changes
Apr 30, 2024
mmoschovas
approved these changes
May 7, 2024
bbaresic
force-pushed
the
faster-deep-clone
branch
from
c753d85 to
3f049c7
Compare
Ticki84
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
May 14, 2024
mefjush
pushed a commit
to adhese/Prebid.js
that referenced
this pull request
May 21, 2024
Merged
1 task
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Prebid currently uses an outdated version of just-clone for deep cloning objects.
After some benchmarking, klona seems much more efficient even compared to other libraries or even native JS (
structuredCloneandJSON.parse/stringify)This PR replaces
just-clone, but the other way of deep-cloningJSON.parse(JSON.stringify(object))stays unchanged.That should be done in a different PR.
This partially addresses #11399.