Skip to content

Commit

Permalink
33across - allow aliasing (#12138)
Browse files Browse the repository at this point in the history
  • Loading branch information
andyblackwell authored Aug 19, 2024
1 parent 4835e08 commit c452306
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
4 changes: 1 addition & 3 deletions modules/33acrossBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ function isBidRequestValid(bid) {
}

function _validateBasic(bid) {
const invalidBidderName = bid.bidder !== BIDDER_CODE && !BIDDER_ALIASES.includes(bid.bidder);

if (invalidBidderName || !bid.params) {
if (!bid.params) {
return false;
}

Expand Down
21 changes: 0 additions & 21 deletions test/spec/modules/33acrossBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -527,27 +527,6 @@ describe('33acrossBidAdapter:', function () {
});
});

it('returns false for invalid bidder name values', function() {
const invalidBidderName = [
undefined,
'33',
'33x',
'thirtythree',
''
];

invalidBidderName.forEach((bidderName) => {
const bid = {
bidder: bidderName,
params: {
siteId: 'sample33xGUID123456789'
}
};

expect(spec.isBidRequestValid(bid)).to.be.false;
});
});

it('returns true for valid guid values', function() {
// NOTE: We ignore whitespace at the start and end since
// in our experience these are common typos
Expand Down

0 comments on commit c452306

Please sign in to comment.