consumableBidAdapter: remove eid non-objects

prebid · Jan 13, 2025 · b043465 · b043465
1 parent 7a210da
commit b043465
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/modules/consumableBidAdapter.js b/modules/consumableBidAdapter.js
@@ -300,6 +300,7 @@ function retrieveAd(decision, unitId, unitName) {
 function handleEids(data, validBidRequests) {
   let bidUserIdAsEids = deepAccess(validBidRequests, '0.userIdAsEids');
   if (isArray(bidUserIdAsEids) && bidUserIdAsEids.length > 0) {
+    bidUserIdAsEids = bidUserIdAsEids.filter(e => typeof e === 'object');
     deepSetValue(data, 'user.eids', bidUserIdAsEids);
   } else {
     deepSetValue(data, 'user.eids', undefined);

diff --git a/test/spec/modules/consumableBidAdapter_spec.js b/test/spec/modules/consumableBidAdapter_spec.js
@@ -755,6 +755,48 @@ describe('Consumable BidAdapter', function () {
       expect(data.user.eids).to.deep.equal(bidderRequest.bidRequest[0].userIdAsEids);
     });
 
+    it("Request should remove non-objects for userIdAsEids", function () {
+      bidderRequest.bidRequest[0].userId = {};
+      bidderRequest.bidRequest[0].userId.tdid = "TTD_ID";
+      bidderRequest.bidRequest[0].userIdAsEids = [
+        {
+          source: "adserver.org",
+          uids: [
+            {
+              id: "TTD_ID_FROM_USER_ID_MODULE",
+              atype: 1,
+              ext: {
+                rtiPartner: "TDID",
+              },
+            },
+          ],
+        },
+        'RANDOM_IDENTIFIER_STRING'
+      ];
+      let scrubbedEids = [
+        {
+          source: "adserver.org",
+          uids: [
+            {
+              id: "TTD_ID_FROM_USER_ID_MODULE",
+              atype: 1,
+              ext: {
+                rtiPartner: "TDID",
+              },
+            },
+          ],
+        },
+      ];
+      let request = spec.buildRequests(
+        bidderRequest.bidRequest,
+        BIDDER_REQUEST_1
+      );
+      let data = JSON.parse(request.data);
+      expect(data.user.eids).to.deep.equal(
+        scrubbedEids
+      );
+    });
+
     it('Request should NOT have adsrvrOrgId params if userId is NOT object', function() {
       let request = spec.buildRequests(bidderRequest.bidRequest, BIDDER_REQUEST_1);
       let data = JSON.parse(request.data);