Skip to content

Commit

Permalink
Revert "Vidazoo Bid Adapter: Add ORTB2 device data to request payload (…
Browse files Browse the repository at this point in the history 
…#12074)"

This reverts commit 6e42abe.
  • Loading branch information
@patmmccann
patmmccann authored Dec 27, 2024
1 parent 0419f1a commit 220e4bb
Show file tree
Hide file tree
Showing 7 changed files with 108 additions and 202 deletions.
2 changes: 0 additions & 2 deletions libraries/vidazooUtils/bidderUtils.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,6 @@ export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidder
const userData = deepAccess(bidderRequest, 'ortb2.user.data', []);
const contentLang = deepAccess(bidderRequest, 'ortb2.site.content.language') || document.documentElement.lang;
const coppa = deepAccess(bidderRequest, 'ortb2.regs.coppa', 0);
const device = deepAccess(bidderRequest, 'ortb2.device', {});

if (isFn(bid.getFloor)) {
const floorInfo = bid.getFloor({
Expand Down Expand Up @@ -291,7 +290,6 @@ export function buildRequestData(bid, topWindowUrl, sizes, bidderRequest, bidder
bidderRequestsCount: bidderRequestsCount,
bidderWinsCount: bidderWinsCount,
bidderTimeout: bidderTimeout,
device,
...uniqueRequestData
};

Expand Down
51 changes: 18 additions & 33 deletions test/spec/modules/illuminBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,36 +94,6 @@ const VIDEO_BID = {
}
}

const ORTB2_DEVICE = {
sua: {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
},
w: 980,
h: 1720,
dnt: 0,
ua: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/125.0.6422.80 Mobile/15E148 Safari/604.1',
language: 'en',
devicetype: 1,
make: 'Apple',
model: 'iPhone 12 Pro Max',
os: 'iOS',
osv: '17.4',
ext: {fiftyonedegrees_deviceId: '17595-133085-133468-18092'},
};

const BIDDER_REQUEST = {
'gdprConsent': {
'consentString': 'consent_string',
Expand All @@ -147,7 +117,24 @@ const BIDDER_REQUEST = {
'gpp_sid': [7],
'coppa': 0
},
'device': ORTB2_DEVICE,
'device': {
'sua': {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
}
}
}
};

Expand Down Expand Up @@ -328,7 +315,6 @@ describe('IlluminBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
uniqueDealId: `${hashUrl}_${Date.now().toString()}`,
uqs: getTopWindowQueryParams(),
mediaTypes: {
Expand Down Expand Up @@ -400,7 +386,6 @@ describe('IlluminBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
url: 'https%3A%2F%2Fwww.greatsite.com',
referrer: 'https://www.somereferrer.com',
cb: 1000,
Expand Down
51 changes: 18 additions & 33 deletions test/spec/modules/kueezRtbBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,36 +93,6 @@ const VIDEO_BID = {
}
}

const ORTB2_DEVICE = {
sua: {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
},
w: 980,
h: 1720,
dnt: 0,
ua: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/125.0.6422.80 Mobile/15E148 Safari/604.1',
language: 'en',
devicetype: 1,
make: 'Apple',
model: 'iPhone 12 Pro Max',
os: 'iOS',
osv: '17.4',
ext: {fiftyonedegrees_deviceId: '17595-133085-133468-18092'},
};

const BIDDER_REQUEST = {
'gdprConsent': {
'consentString': 'consent_string',
Expand All @@ -146,7 +116,24 @@ const BIDDER_REQUEST = {
'gpp_sid': [7],
'coppa': 0
},
'device': ORTB2_DEVICE,
'device': {
'sua': {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
}
}
}
};

Expand Down Expand Up @@ -334,7 +321,6 @@ describe('KueezRtbBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
uniqueDealId: `${hashUrl}_${Date.now().toString()}`,
uqs: getTopWindowQueryParams(),
mediaTypes: {
Expand Down Expand Up @@ -408,7 +394,6 @@ describe('KueezRtbBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
url: 'https%3A%2F%2Fwww.greatsite.com',
referrer: 'https://www.somereferrer.com',
cb: 1000,
Expand Down
51 changes: 18 additions & 33 deletions test/spec/modules/shinezRtbBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,36 +94,6 @@ const VIDEO_BID = {
}
}

const ORTB2_DEVICE = {
sua: {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
},
w: 980,
h: 1720,
dnt: 0,
ua: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/125.0.6422.80 Mobile/15E148 Safari/604.1',
language: 'en',
devicetype: 1,
make: 'Apple',
model: 'iPhone 12 Pro Max',
os: 'iOS',
osv: '17.4',
ext: {fiftyonedegrees_deviceId: '17595-133085-133468-18092'},
};

const BIDDER_REQUEST = {
'gdprConsent': {
'consentString': 'consent_string',
Expand All @@ -149,7 +119,24 @@ const BIDDER_REQUEST = {
'gpp_sid': [7],
'coppa': 0
},
'device': ORTB2_DEVICE,
'device': {
'sua': {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
}
}
}
};

Expand Down Expand Up @@ -330,7 +317,6 @@ describe('ShinezRtbBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
uniqueDealId: `${hashUrl}_${Date.now().toString()}`,
uqs: getTopWindowQueryParams(),
mediaTypes: {
Expand Down Expand Up @@ -402,7 +388,6 @@ describe('ShinezRtbBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
url: 'https%3A%2F%2Fwww.greatsite.com',
referrer: 'https://www.somereferrer.com',
cb: 1000,
Expand Down
51 changes: 18 additions & 33 deletions test/spec/modules/tagorasBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,36 +94,6 @@ const VIDEO_BID = {
}
}

const ORTB2_DEVICE = {
sua: {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
},
w: 980,
h: 1720,
dnt: 0,
ua: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/125.0.6422.80 Mobile/15E148 Safari/604.1',
language: 'en',
devicetype: 1,
make: 'Apple',
model: 'iPhone 12 Pro Max',
os: 'iOS',
osv: '17.4',
ext: {fiftyonedegrees_deviceId: '17595-133085-133468-18092'},
};

const BIDDER_REQUEST = {
'gdprConsent': {
'consentString': 'consent_string',
Expand All @@ -147,7 +117,24 @@ const BIDDER_REQUEST = {
'gpp_sid': [7],
'coppa': 0
},
'device': ORTB2_DEVICE,
'device': {
'sua': {
'source': 2,
'platform': {
'brand': 'Android',
'version': ['8', '0', '0']
},
'browsers': [
{'brand': 'Not_A Brand', 'version': ['99', '0', '0', '0']},
{'brand': 'Google Chrome', 'version': ['109', '0', '5414', '119']},
{'brand': 'Chromium', 'version': ['109', '0', '5414', '119']}
],
'mobile': 1,
'model': 'SM-G955U',
'bitness': '64',
'architecture': ''
}
}
}
};

Expand Down Expand Up @@ -327,7 +314,6 @@ describe('TagorasBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
uniqueDealId: `${hashUrl}_${Date.now().toString()}`,
uqs: getTopWindowQueryParams(),
mediaTypes: {
Expand Down Expand Up @@ -398,7 +384,6 @@ describe('TagorasBidAdapter', function () {
'bitness': '64',
'architecture': ''
},
device: ORTB2_DEVICE,
url: 'https%3A%2F%2Fwww.greatsite.com',
referrer: 'https://www.somereferrer.com',
cb: 1000,
Expand Down
Loading

0 comments on commit 220e4bb

Please sign in to comment.