Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing space in hydration mismatch message #4602

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

sirreal
Copy link
Contributor

@sirreal sirreal commented Dec 10, 2024

The message reads something like this:

Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

It should read

Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

"templateas" should be "template as"

-Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.
+Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

The message reads something like this:

> Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

It should read

> Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

```diff
-Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.
+Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.
```
@coveralls
Copy link

Coverage Status

coverage: 99.617%. remained the same
when pulling d2904b9 on sirreal:patch-1
into 5c9625a on preactjs:main.

@marvinhagemeister marvinhagemeister merged commit eba80f7 into preactjs:main Dec 10, 2024
13 checks passed
@sirreal sirreal deleted the patch-1 branch December 10, 2024 17:27
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants