feat: support precompiled JSX transform #4177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.8 kB (3%) Total Size: 59.2 kB
ℹ️ View Unchanged
|
marvinhagemeister
force-pushed
the
jsxssr
branch
from
d1713fe to
f88bf02
Compare
marvinhagemeister
requested review from
developit,
andrewiggins and
JoviDeCroock
jsx-runtime/src/encode.js
Outdated
| const ENCODED_ENTITIES = /["&<]/; | ||
|
|
||
| /** @param {string} str */ | ||
| export function encodeEntities(str) { |
There was a problem hiding this comment.
This function is just copied over from preact-render-to-string https://github.com/preactjs/preact-render-to-string/blob/17f839c47309d7de35cc407c25b016a0dcc325c8/src/util.js#L11
JoviDeCroock
approved these changes
Oct 31, 2023
marvinhagemeister
force-pushed
the
jsxssr
branch
from
f88bf02 to
29e3ada
Compare
JoviDeCroock
reviewed
Nov 6, 2023
JoviDeCroock
approved these changes
Nov 6, 2023
marvinhagemeister
force-pushed
the
jsxssr
branch
from
ca1ac38 to
975779a
Compare
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new precompile JSX transform that will ship with the next deno version. The new deno version will come out this week.
The idea behind the precompile JSX transform is that instead of allocating a full vnode object + props for every element, we precompile HTML nodes during the JSX transpilation step to strings. During rendering we then need to mostly only concatenate strings together.
Demo: https://github.com/marvinhagemeister/deno-jsx-precompile-preact-demo
See preactjs/preact-render-to-string#322 .