Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jeongminsang] UI 작업 #27

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

[jeongminsang] UI 작업 #27

wants to merge 5 commits into from

Conversation

jeongminsang
Copy link
Member

@jeongminsang jeongminsang commented May 5, 2023 •
edited
Loading

  • UI 작업
  • input value가 true이고 api데이터가 없을 때만 "검색어 없음"이 출력되도록 수정
  • 데이터 참조 에러 수정
    uiui

@jeongminsang jeongminsang added the enhancement New feature or request label May 5, 2023
@jeongminsang jeongminsang self-assigned this May 5, 2023
@jeongminsang jeongminsang linked an issue May 5, 2023 that may be closed by this pull request
UI 작업 및 리드미 작성 #4
Closed
2 tasks
woongsnote
woongsnote reviewed May 5, 2023
View reviewed changes
Copy link

@woongsnote woongsnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요구사항에 없없지만 출력한 검색어의 개수에 제한을 두신 게 인상적이네요 👍

@hyukzz
Copy link
Contributor

hyukzz commented May 5, 2023

최대 검색어 갯수를 7개로 딱 제한하신건가요??

JunJongHun
JunJongHun reviewed May 5, 2023
View reviewed changes
Copy link

@JunJongHun JunJongHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오..완전 똑같아요😄

04ian80
04ian80 reviewed May 5, 2023
View reviewed changes
src/App.css
}
.container {
display: flex;
flex-direction: row;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 block이 기본값인 요소에 flex 넣을 때 flex-direction 안 넣고 작업해왔는데 혹시 이 속성을 쓸때랑 안쓸때의 차이가 있나요?

@rabbit-22 rabbit-22 mentioned this pull request May 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@04ian80 04ian80 04ian80 left review comments

@JunJongHun JunJongHun JunJongHun left review comments

@woongsnote woongsnote woongsnote left review comments

Assignees

@jeongminsang jeongminsang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI 작업 및 리드미 작성
5 participants
@jeongminsang @hyukzz @woongsnote @JunJongHun @04ian80