Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yan9vvoojin] UI 작업 #26

Closed
wants to merge 12 commits into from
Closed

Conversation

yan9vvoojin
Copy link

작업내용

  • UI 작업

1

@yan9vvoojin yan9vvoojin self-assigned this May 5, 2023
@yan9vvoojin yan9vvoojin added the enhancement New feature or request label May 5, 2023
@yan9vvoojin yan9vvoojin linked an issue May 5, 2023 that may be closed by this pull request
2 tasks
Copy link

@woongsnote woongsnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 라이브러리 설치 없이, 아이콘 구현하신 부분이 인상적이네요 👍

@hyukzz
Copy link
Contributor

hyukzz commented May 5, 2023

혹시 최대 7개 데이터만 딱 잘라서 보여주는 형식인가요??

Comment on lines +2 to +9
<svg
viewBox="0 0 16 16"
fill="currentColor"
preserveAspectRatio="none"
xmlns="http://www.w3.org/2000/svg"
>
<path d="M6.56 0a6.56 6.56 0 015.255 10.49L16 14.674 14.675 16l-4.186-4.184A6.56 6.56 0 116.561 0zm0 1.875a4.686 4.686 0 100 9.372 4.686 4.686 0 000-9.372z"></path>
</svg>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-icons 라이브러리 말고 svg를 사용하신 이유가 똑같은 돋보기 모양을 사용하고 싶어서 이셨나요? 아니면 나중에 svg는 벡터 기반이기 때문에 커스텀을 좋으니까 사용하신건가요~?

@jeongminsang jeongminsang mentioned this pull request May 5, 2023
2 tasks
@04ian80
Copy link
Member

04ian80 commented May 5, 2023

포커싱 될때 글자가 하얀색으로 변하는 것까지 스타일링 하셨네요, 깔끔해서 보기 좋습니다!

@yan9vvoojin
Copy link
Author

혹시 최대 7개 데이터만 딱 잘라서 보여주는 형식인가요??

넵! 클론하는 사이트에서 최대 7개까지만 보여주길래 저도 그렇게 했습니다~

@yan9vvoojin yan9vvoojin closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI 작업 및 리드미 작성
5 participants