Skip to content

Commit

Permalink
Merge pull request #66 from practo/v1.0.0-beta-update
Browse files Browse the repository at this point in the history
Update the release number to v1.0.0-beta
  • Loading branch information
alok87 authored Apr 16, 2020
2 parents 859ffd5 + 2f8318f commit 1cf1e7b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Kubernetes does support custom metric scaling using Horizontal Pod Autoscaler. B
## Release
- Decide a `tag` and bump up the `tag` [here](https://github.com/practo/k8s-worker-pod-autoscaler/blob/master/artifacts/deployment-template.yaml#L26) and create and merge the pull request.
- Decide a `tag` and bump up the `tag` [here](https://github.com/practo/k8s-worker-pod-autoscaler/blob/master/artifacts/deployment-template.yaml#L31) and create and merge the pull request.
- Get the latest master code.
```
Expand All @@ -164,11 +164,11 @@ git pull origin master
- Build and push the image to `hub.docker.com/practodev`. Note: practodev push access is required.
```
git fetch --tags
git tag v0.2.2
git tag v1.0.0-beta
make push
```
- Create a Release in Github. Refer this https://github.com/practo/k8s-worker-pod-autoscaler/releases/tag/v0.2.0 and create a release. Release should contain the Changelog information of all the issues and pull request after the last release.
- Create a Release in Github. Refer this https://github.com/practo/k8s-worker-pod-autoscaler/releases/tag/v1.0.0-beta and create a release. Release should contain the Changelog information of all the issues and pull request after the last release.
- Publish the release in Github 🎉
Expand All @@ -180,7 +180,7 @@ kubectl edit deployment -n kube-system workerpodautoscaler
```
## Contributing
It would be really helpful to add all the major message queuing service providers. This [interface](https://github.com/practo/k8s-worker-pod-autoscaler/blob/master/pkg/queue/queueing_service.go#L5-L8) implementation needs to be written down to make that possible.
It would be really helpful to add all the major message queuing service providers. This [interface](https://github.com/practo/k8s-worker-pod-autoscaler/blob/master/pkg/queue/queueing_service.go#L5-L14) implementation needs to be written down to make that possible.
- After making code changes, run the below commands to build and run locally.
```
Expand Down
2 changes: 1 addition & 1 deletion artifacts/deployment-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
value: {{ WPA_AWS_ACCESS_KEY_ID }}
- name: AWS_SECRET_ACCESS_KEY
value: {{ WPA_AWS_SECRET_ACCESS_KEY }}
image: practodev/workerpodautoscaler:v0.2.2
image: practodev/workerpodautoscaler:v1.0.0-beta
imagePullPolicy: Always
command:
- /workerpodautoscaler
Expand Down

0 comments on commit 1cf1e7b

Please sign in to comment.