Provide a new garbage-collection mechanism #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce the configuration `min_available_memory` which causes disconnected clients to be cleaned up when the available system memory drops below this amount. While this is compatible with the `instance_timeout` setting, it provides an alternative; letting `rust-analyzer` processes live forever unless memory gets low.
paholg
force-pushed
the
min_available_memory
branch
from
0a91981 to
1210085
Compare
pr2502
reviewed
Sep 21, 2023
| @@ -117,6 +121,7 @@ impl InstanceKey { | |||
|
|
|||
| pub struct RaInstance { | |||
| pid: u32, | |||
| spawned_at: Instant, | |||
There was a problem hiding this comment.
Could we use the time the last client has disconnected from the instance instead of when it was spawned? That seems like a better indicator which instance is the least useful to keep around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce the configuration
min_available_memorywhich causes disconnected clients to be cleaned up when the available system memory drops below this amount.While this is compatible with the
instance_timeoutsetting, it provides an alternative; lettingrust-analyzerprocesses live forever unless memory gets low.