Remove randombytes.c and add notrandombytes.c #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
force-pushed
the
randombytes
branch
2 times, most recently
from
940e262 to
b874aa8
Compare
mkannwischer
force-pushed
the
randombytes
branch
2 times, most recently
from
17aa104 to
5ea0335
Compare
hanno-becker
approved these changes
Oct 28, 2024
This removes our current randombytes() implementation and replaces it with a deterministic randombytes() based on surf (https://cr.yp.to/hash.html#surf). Resolves #260. As per pq-code-package/tsc#86, the consensus of the PQCP TCP is that a secure implementation of randombytes() should be provided by the software consuming code from the PQCP. For testing, we should use a deterministic randombytes() that no one is going to put into a production system. I propose to use the popular implementation by Daniel J. Bernstein based on surf (https://cr.yp.to/hash.html#surf). This implementation is clearly not secure which hopefully decreases the risk of someone just taking it. I called it notrandombytes.c and moved it into the test folder to decrease the risk of misuse. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
force-pushed
the
randombytes
branch
from
5ea0335 to
f359556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our current
randombytes()implementation and replaces it with a deterministicrandombytes()based on surf (https://cr.yp.to/hash.html#surf).Resolves #260.
As per pq-code-package/tsc#86, the consensus of the PQCP TCP is that a secure implementation of
randombytes()should be provided by the software consuming code from the PQCP.For testing, we should use a deterministic
randombytes()that no one is going to put into a production system. I propose to use the popular implementation by Daniel J. Bernstein based on surf (https://cr.yp.to/hash.html#surf).This implementation is clearly not secure which hopefully decreases the risk of someone just taking it.
I called it
notrandombytes.cand moved it into the test folder to decrease the risk of misuse.