Remove TODO regarding unrolling of gen_matrix()

Our performance numbers suggest that the unrolling either already works or is not needed, so remove the corresponding TODO. Signed-off-by: Hanno Becker <[email protected]>
pq-code-package · Dec 3, 2024 · 5cdbeea · 5cdbeea
1 parent 7df044e
commit 5cdbeea
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/mlkem/indcpa.c b/mlkem/indcpa.c
@@ -293,13 +293,6 @@ void gen_matrix(polyvec *a, const uint8_t seed[MLKEM_SYMBYTES], int transposed)
     memcpy(seedxy[j], seed, MLKEM_SYMBYTES);
   }
 
-  /*
-   * TODO: All loops in this function should be unrolled for decent
-   * performance.
-   * Either add suitable pragmas, or split gen_matrix according to MLKEM_K
-   * and unroll by hand.
-   */
-
   for (i = 0; i < (MLKEM_K * MLKEM_K / KECCAK_WAY) * KECCAK_WAY;
        i += KECCAK_WAY)
   {