Code

Plonky3 keccak optimization#2089

Code

Open

qwang98 wants to merge 42 commits intomainpowdr-labs/powdr:mainfrom plonky3-keccak-memory-new-newpowdr-labs/powdr:plonky3-keccak-memory-new-newCopy head branch name to clipboard

+193-223

Commits

Commits on Sep 13, 2024

• messed up commit history again...

  qwang98

  committed
  2784378

• test passed'

  qwang98

  committed
  e96fca7

• fixed comments'

  qwang98

  committed
  3f0a7a8

• used unchagnd api

  qwang98

  committed
  6c82727

Commits on Sep 16, 2024

• just to rerun CI

  qwang98

  committed
  f4b3376

• minor

  qwang98

  committed
  a0feb54

• Merge branch 'main' into plonky3-keccak-new-new

  qwang98

  committed
  628eb79

• removed reverse

  qwang98

  committed
  6cba5dc

Commits on Sep 17, 2024

• fix

  qwang98

  committed
  98a6ea2

• example for chris

  qwang98

  committed
  79045b0

• not the pil

  qwang98

  committed
  49e2670

• some failed attempts of adapting to nested array

  qwang98

  committed
  29a203d

• all fixed

  qwang98

  committed
  66ad3af

• remove txt

  qwang98

  committed
  6a0de54

Commits on Sep 18, 2024

• added keccakf to test pipeline

  qwang98

  committed
  73c608d

Commits on Sep 23, 2024

• fix from georg

  qwang98

  committed
  0bfc318

Commits on Sep 24, 2024

• POC for keccak memory

  qwang98

  committed
  d36392c

• deleted unwanted

  qwang98

  committed
  ce1e6ad

• Merge branch 'main' into plonky3-keccak-memory-new

  qwang98

  committed
  1b9975a

Commits on Oct 19, 2024

• Merge branch 'main' into plonky3-keccak-memory-new

  qwang98

  committed
  03d502a

Commits on Oct 20, 2024

• revamped memory machine; still have bugs in witgen

  qwang98

  committed
  f51f03a

Commits on Oct 23, 2024

• modified memory address calculation to start from final step latch row, but still won't work due to not enough auto witgen passes for memory read and write

  qwang98

  committed
  256c9a0

Commits on Oct 26, 2024

• keccak memory works fully

  qwang98

  committed
  205b51a

• added detailed comments on methodology and efficiency

  qwang98

  committed
  b0499e9

• removed outdated memory submachine tests

  qwang98

  committed
  56cefaa

Commits on Nov 4, 2024

• addressed all comments

  qwang98

  committed
  3a15b65

• Merge branch 'main' into plonky3-keccak-memory-new

  qwang98

  committed
  061c256

• created address_inc_cond function that uses increment_ptr; witness generation time is similar as using links to add_sub

  qwang98

  committed
  0bda79a

Commits on Nov 14, 2024

• moved pointer coinstraints to addr_h and addr_l columns

  qwang98

  committed
  fa8a4cc

• Merge branch 'main' into plonky3-keccak-memory-new-new

  qwang98

  committed
  2f65fb9

• updated pipeline

  qwang98

  committed
  931a5d6

Commits on Nov 25, 2024

• fixed high degree

  qwang98

  committed
  c6dd8fd

• merge main

  qwang98

  committed
  fbd45ca

• weird witgen bug emerged again

  qwang98

  committed
  d12fa46

• successful calculation of input and output addresses using inverse and carry; correct calculation of first round values; however witgen stopped by the bug 'we have been stuck in the same row for 10…

  Show description for 67414af
  qwang98

  committed
  67414af

• changing MAX_ROUNDS_PER_ROW_DELTA to 102 or above solves the bug and tests all pass

  qwang98

  committed
  11972db

Commits on Nov 26, 2024

• removed print statement due to CI error

  qwang98

  committed
  06d40f4

• delete unrelated output

  qwang98

  committed
  5ad8bec

Commits on Dec 6, 2024

• deleted output txt example:

  qwang98

  committed
  096560e

Commits on Dec 9, 2024

• fix test

  leonardoalt

  committed
  f3a2230

• Merge remote-tracking branch 'origin/main' into plonky3-keccak-memory-new-new

  leonardoalt

  committed
  88e860c

• fix merge

  leonardoalt

  committed
  ae5deab