#35568 Fixing warnings

.gitignore

@@ -27,4 +27,5 @@ eng/tools
 packages/
 source-dependencies/
 .tools/
+.config/dotnet-tools.json
 */.obsidian/*

code/DebugDemo/Entities.cs

@@ -1,11 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 namespace DebugDemo
 {
     public class Student

code/DebugDemo/Fabric.cs

@@ -3,19 +3,13 @@
 using Metalama.Documentation.QuickStart;
 using Metalama.Framework.Code;
 using Metalama.Framework.Fabrics;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace DebugDemo
 {
     public class Fabric : ProjectFabric
     {
         public override void AmendProject( IProjectAmender amender )
         {
-
             var allPublicMethods = amender
                 .SelectTypes() // Get all types 
                 .SelectMany( t => t.Methods )  // Get all methods

code/DebugDemo/Program.cs

@@ -5,7 +5,7 @@
 
 namespace DebugDemo
 {
-    public class Demo
+    public static class Demo
     {
         public static void Main()
         {

code/DebugDemo2/Fabric2.cs

@@ -1,7 +1,6 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
 using Metalama.Documentation.QuickStart;
-using Metalama.Framework.Code;
 using Metalama.Framework.Fabrics;
 
 namespace DebugDemo2

code/Metalama.Documentation.Helpers/ConsoleApp/ConsoleApp.cs

@@ -1,18 +1,12 @@
 // This is public domain Metalama sample code.
 
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 
 namespace Metalama.Documentation.Helpers.ConsoleApp;
 
-public class ConsoleApp : IDisposable, IAsyncDisposable
+public class ConsoleApp( ServiceProvider serviceProvider ) : IDisposable, IAsyncDisposable
 {
-    public ServiceProvider Services { get; }
-
-    public ConsoleApp( ServiceProvider serviceProvider )
-    {
-        this.Services = serviceProvider;
-    }
+    public ServiceProvider Services { get; } = serviceProvider;
 
     public static ConsoleAppBuilder CreateBuilder() => new();
 

code/Metalama.Documentation.QuickStart.Fabrics.2/BaseClass.cs

@@ -1,11 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 namespace Metalama.Documentation.QuickStart.Fabrics
 {
     public class BaseClass { }

code/Metalama.Documentation.QuickStart.Fabrics.2/Demo.cs

@@ -1,11 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 namespace Metalama.Documentation.QuickStart.Fabrics
 {
     internal class Demo { }

code/Metalama.Documentation.QuickStart.Fabrics/Demo.cs

@@ -1,11 +1,5 @@
 // Copyright (c) SharpCrafters s.r.o. See the LICENSE.md file in the root directory of this repository root for details.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
 namespace Metalama.Documentation.QuickStart.Fabrics
 {
     public class Demo

code/Metalama.Documentation.QuickStart.Fabrics/NPCFabric.cs

@@ -2,7 +2,6 @@
 
 using Metalama.Framework.Code;
 using Metalama.Framework.Fabrics;
-using Metalama.Documentation.QuickStart;
 
 namespace Metalama.Documentation.QuickStart.Fabrics
 {

code/Metalama.Documentation.SampleCode.AspectFramework/AddEditorBrowsableAttribute_Introduced_Programmatic.cs

@@ -2,7 +2,7 @@
 
 namespace Doc.AddEditorBrowsableAttribute_Introduced_Programmatic;
 
-[AddEditorHiddenFieldAttribute]
+[AddEditorHiddenField]
 public class C
 {
     public int NormalField;

code/Metalama.Documentation.SampleCode.AspectFramework/AddEditorBrowsableAttribute_Introduced_Programmatic.t.cs

@@ -1,6 +1,6 @@
 using System.ComponentModel;
 namespace Doc.AddEditorBrowsableAttribute_Introduced_Programmatic;
-[AddEditorHiddenFieldAttribute]
+[AddEditorHiddenField]
 public class C
 {
   public int NormalField;

code/Metalama.Documentation.SampleCode.AspectFramework/AuxiliaryTemplate_TemplateInvocation.Aspect.cs

@@ -59,8 +59,6 @@ protected override void AroundCaching( TemplateInvocation templateInvocation )
                 catch ( Exception ex ) when ( i < 10 )
                 {
                     Console.WriteLine( ex.ToString() );
-
-                    continue;
                 }
             }
         }

code/Metalama.Documentation.SampleCode.AspectFramework/AuxiliaryTemplate_TemplateInvocation.t.cs

@@ -37,7 +37,6 @@ public int Rmove(int a, int b)
       catch (Exception ex)when (i < 10)
       {
         Console.WriteLine(ex.ToString());
-        continue;
       }
     }
     return default;

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled.Aspect.cs

@@ -2,10 +2,8 @@
 
 using Metalama.Framework.Advising;
 using System;
-using System.Linq;
 using Metalama.Framework.Aspects;
 using Metalama.Framework.Code;
-using Metalama.Framework.Fabrics;
 
 namespace Doc.Decoupled;
 

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled.Attribute.cs

@@ -6,7 +6,7 @@
 
 namespace Doc.Decoupled;
 
-[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property)]
+[AttributeUsage( AttributeTargets.Method | AttributeTargets.Property )]
 [RunTimeOrCompileTime]
 public class LogAttribute : Attribute, ICompileTimeSerializable
 {

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled.Fabric.cs

@@ -1,6 +1,4 @@
-using Metalama.Framework.Advising;
-using System;
-using System.Linq;
+using System.Linq;
 using Metalama.Framework.Aspects;
 using Metalama.Framework.Code;
 using Metalama.Framework.Fabrics;

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled.cs

@@ -1,7 +1,5 @@
 // This is public domain Metalama sample code.
 
-using EmptyFiles;
-
 namespace Doc.Decoupled;
 
 public class C

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled.t.cs

@@ -1,5 +1,4 @@
 using System;
-using EmptyFiles;
 namespace Doc.Decoupled;
 public class C
 {

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled_Ref.Aspect.cs

@@ -2,10 +2,8 @@
 
 using Metalama.Framework.Advising;
 using System;
-using System.Linq;
 using Metalama.Framework.Aspects;
 using Metalama.Framework.Code;
-using Metalama.Framework.Fabrics;
 
 namespace Doc.Decoupled_Ref;
 

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled_Ref.Attribute.cs

@@ -2,7 +2,7 @@
 
 namespace Doc.Decoupled_Ref;
 
-[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property)]
+[AttributeUsage( AttributeTargets.Method | AttributeTargets.Property )]
 public class LogAttribute : Attribute
 {
     public string Category { get; set; } = "default";

code/Metalama.Documentation.SampleCode.AspectFramework/Decoupled_Ref.Fabric.cs

@@ -11,7 +11,7 @@ public class Fabric : ProjectFabric
 {
     public override void AmendProject( IProjectAmender amender )
     {
-        var declarations = amender.SelectDeclarationsWithAttribute( typeof(LogAttribute));
+        var declarations = amender.SelectDeclarationsWithAttribute( typeof(LogAttribute) );
 
         declarations
             .OfType<IMethod>()

code/Metalama.Documentation.SampleCode.AspectFramework/ForTestOnly_Fabric.Fabric.cs

@@ -27,7 +27,7 @@ public override void AmendNamespace( INamespaceAmender amender )
             private void ValidateReference( ReferenceValidationContext context )
             {
                 if (
-                    context.Origin.Namespace != context.Destination.Declaration &&
+                    !Equals( context.Origin.Namespace, context.Destination.Declaration ) &&
                     !context.Origin.Namespace.FullName.EndsWith(
                         ".Tests",
                         StringComparison.Ordinal ) )

code/Metalama.Documentation.SampleCode.AspectFramework/GenerateResetMethods.Aspect.cs

@@ -18,7 +18,7 @@ public override void BuildAspect( IAspectBuilder<INamedType> builder )
         {
             builder.IntroduceMethod(
                 nameof(this.Reset),
-                args: new { field = field, T = field.Type },
+                args: new { field, T = field.Type },
                 buildMethod: m => m.Name = "Reset" + CamelCase( field.Name ) );
         }
     }

code/Metalama.Documentation.SampleCode.AspectFramework/IntroduceNestedClass_Members.Aspect.cs

@@ -3,8 +3,6 @@
 using Metalama.Framework.Advising;
 using Metalama.Framework.Aspects;
 using Metalama.Framework.Code;
-using System.Collections.Generic;
-using System.ComponentModel.DataAnnotations;
 using System.Linq;
 
 namespace Doc.IntroduceNestedClass_Members;

code/Metalama.Documentation.SampleCode.AspectFramework/Normalize.Aspect.cs

@@ -14,7 +14,7 @@ public override void BuildAspect( IAspectBuilder<IFieldOrProperty> builder )
     }
 
     [Template]
-    private string OverrideProperty
+    private string? OverrideProperty
     {
         set => meta.Target.FieldOrProperty.Value = value?.Trim().ToLowerInvariant();
     }

code/Metalama.Documentation.SampleCode.AspectFramework/RegisterInstance.cs

@@ -5,7 +5,7 @@ namespace Doc.RegisterInstance;
 [RegisterInstance]
 internal class DemoClass
 {
-    public DemoClass() : base() { }
+    public DemoClass() { }
 
     public DemoClass( int i ) : this() { }
 

code/Metalama.Documentation.SampleCode.AspectFramework/RegisterInstance.t.cs

@@ -3,7 +3,7 @@ namespace Doc.RegisterInstance;
 [RegisterInstance]
 internal class DemoClass
 {
-  public DemoClass() : base()
+  public DemoClass()
   {
     _instanceRegistryHandle = InstanceRegistry.Register(this);
   }

code/Metalama.Documentation.SampleCode.AspectFramework/SwitchStatementBuilder.cs

@@ -1,10 +1,5 @@
 // This is public domain Metalama sample code.
 
-using Metalama.Framework.Aspects;
-using Metalama.Framework.Code.SyntaxBuilders;
-using System;
-using System.Linq;
-
 namespace Doc.SwitchStatementBuilder_;
 
 [Dispatch]

code/Metalama.Documentation.SampleCode.AspectFramework/SwitchStatementBuilder.t.cs

@@ -1,7 +1,4 @@
-using Metalama.Framework.Aspects;
-using Metalama.Framework.Code.SyntaxBuilders;
 using System;
-using System.Linq;
 namespace Doc.SwitchStatementBuilder_;
 [Dispatch]
 public class FruitProcessor

code/Metalama.Documentation.SampleCode.AspectFramework/SwitchStatementBuilder_FullTemplate.cs

@@ -1,10 +1,5 @@
 // This is public domain Metalama sample code.
 
-using Metalama.Framework.Aspects;
-using Metalama.Framework.Code.SyntaxBuilders;
-using System;
-using System.Linq;
-
 namespace Doc.SwitchStatementBuilder_FullTemplate;
 
 [Dispatch]

code/Metalama.Documentation.SampleCode.Caching/AzureSynchronized/AzureSynchronized.Program.cs

@@ -36,18 +36,18 @@ private static async Task RunApp( string name )
                     backend =>
                         backend.Memory()
                             .WithAzureSynchronization(
-                                connectionString ) ) ); 
+                                connectionString ) ) );
         // [<endsnippet AddMetalamaCaching>]
 
         // Add other components as usual.
         builder.Services.AddAsyncConsoleMain<ConsoleMain>();
         builder.Services.AddSingleton<ProductCatalogue>();
 
         // Build the application.
-        await using var app = builder.Build( new[] { name } );
+        await using var app = builder.Build( [name] );
 
         // [<snippet Initialize>]
-        await app.Services.GetRequiredService<ICachingService>().InitializeAsync(); 
+        await app.Services.GetRequiredService<ICachingService>().InitializeAsync();
         // [<endsnippet Initialize>]
 
         // Run the application.