-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and check workflow for MS Windows #134
Build and check workflow for MS Windows #134
Conversation
Why did you remove the "Show ... regression.diffs" steps, @vitcpp ? For what it's worth, I'd like to see a similar macOS build and check workflow (in a separate PR, of course). |
Hi @esabol, I've added the missed step. Thank you. I still failed to implement crushtest for windows. I would prefer to merge this PR without crushtest right now and come back to crushtest implementation later. This PR is not an ideal solution because it takes a lot of time to build postgresql of a particular version. I haven't found suitable packages which I can use to build pgSphere under msys2. Please, let me know if you have some ideas. I agree about macOS, let me think about it. |
OK. crushtest doesn't work? |
Well, two tests from crushtest are failed because they run perl from psql using '!' command to generate some input data. It seems, due to some differences in path handling between mswin and linux, it fails. I think, i will try to fight with it one day more. Failed tests:
|
@vitcpp : Maybe try this: https://stackoverflow.com/a/60772585/5153779 |
Well, I'm not sure it could help. On the screenshot below you can see the error under ms win. psql seems to interpret testsuite as an external command unfortunately. As I understood, your solution proposes to copy the perl binary to path, where it can be found with the linux shebang. I believe, the error occurs before using shebang. If I change / -> \ in testsuite/gen_point..., it opens a notepad with the script :) My solution is to add perl command which can be found in PATH variable for linux and ms win. There should be no problems on both systems. |
Add workflow for build and test for MS Windows with USE_HEALPIX = 0 only.